Detach NSG from subnet before deletion#3668
Merged
openshift-merge-bot[bot] merged 5 commits intoAzure:mainfrom Jan 9, 2026
Merged
Detach NSG from subnet before deletion#3668openshift-merge-bot[bot] merged 5 commits intoAzure:mainfrom
openshift-merge-bot[bot] merged 5 commits intoAzure:mainfrom
Conversation
bennerv
force-pushed
the
aro-23244-detatch-nsg-from-subnet
branch
from
3cc5825 to
0620f60
Compare
Member
Author
|
/retest |
… to fail if any step fails
bennerv
force-pushed
the
aro-23244-detatch-nsg-from-subnet
branch
from
0620f60 to
22538a6
Compare
Member
Author
|
/retest |
tsatam
approved these changes
Jan 9, 2026
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bennerv, tsatam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aro-23244
What
Occasionally, deleting a resource group will error out when there's an NSG and a vnet with that NSG attached to one or more subnets. It will error out with a message similar to: "NSG must be detached from subnet before deletion"
Why
Allows deletion to succeed.
Special notes for your reviewer
There are some additional changes in this PR including:
perItOrDescribeTestContexttype to not pass clients to functions on the type when the type itself has access to grab the functions itself.