Detach NSG from subnet before deletion

[bennerv]

aro-23244

What

Occasionally, deleting a resource group will error out when there's an NSG and a vnet with that NSG attached to one or more subnets. It will error out with a message similar to: "NSG must be detached from subnet before deletion"

Why

Allows deletion to succeed.

Special notes for your reviewer

There are some additional changes in this PR including:

• refactor our usage of Azure clients to leverage them from within the perItOrDescribeTestContext type to not pass clients to functions on the type when the type itself has access to grab the functions itself.
• removes a call to an unlocked function when it should be using the function with a mutex behind it

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bennerv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• test/OWNERS [bennerv]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bennerv]

/retest

[openshift-ci]

@bennerv: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-parallel	0c8fbc4	link	true	/test e2e-parallel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.