Skip to content

Conversation

@deads2k
Copy link
Collaborator

@deads2k deads2k commented Jan 19, 2026

pushing so I don't lose it. I owe this to Miguel

Important detail. The current serialization has the strings as omitempty, so we won't be deserializing an empty string.

I found and used the rules in
func (s *Server) createCluster(w http.ResponseWriter, r *http.Request) {
@openshift-ci
Copy link

openshift-ci bot commented Jan 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from mbarnes and roivaz January 19, 2026 23:02
@openshift-ci
Copy link

openshift-ci bot commented Jan 19, 2026

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration f59ee06 link true /test integration
ci/prow/verify f59ee06 link true /test verify
ci/prow/test-unit f59ee06 link true /test test-unit
ci/prow/lint f59ee06 link true /test lint
ci/prow/images f59ee06 link true /test images
ci/prow/e2e-parallel f59ee06 link true /test e2e-parallel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants