Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend health should not depend on Database #529

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Frontend health should not depend on Database #529

wants to merge 3 commits into from

Commits on Aug 21, 2024

  1. Remove dependecy to database from healthchecks 

    Health of services should not depend on upstream depending services. If CosmosDB is not reachable, frondtend would scale down. This could cause an even more catastrophic failure
    @janboll
    janboll committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    5b5daff View commit details
    Browse the repository at this point in the history

  2. Use global prometheus registry 

    We are using default handler, this requires using the default registry everywhere. This was discovered, cause Gauge metrics where not registred/showing in the metrics output.

Also adapt tests to use a global metrics emmiter to avoid panics cause by re-registering metrics in the global registry
    @janboll
    janboll committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    99340a9 View commit details
    Browse the repository at this point in the history

  3. Fix lint

    @janboll
    janboll committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    3bd7dc4 View commit details
    Browse the repository at this point in the history