Conversation
4 tasks
geoberle
force-pushed
the
hypershift-helm
branch
from
aefa276 to
4808b03
Compare
geoberle
added a commit
to geoberle/hypershift
that referenced
this pull request
Oct 13, 2024
Introduce a install helm command to generate a helm chart with some templatization options similar to the install render --template command. the PR also introduces a way to template the registry overrides option of the operator required by Azure/ARO-HCP#698 Signed-off-by: Gerd Oberlechner <[email protected]>
geoberle
added a commit
to geoberle/hypershift
that referenced
this pull request
Oct 17, 2024
Introduce a install helm command to generate a helm chart with some templatization options similar to the install render --template command. the PR also introduces a way to template the registry overrides option of the operator required by Azure/ARO-HCP#698 Signed-off-by: Gerd Oberlechner <[email protected]>
geoberle
added a commit
to geoberle/hypershift
that referenced
this pull request
Oct 18, 2024
Introduce a install helm command to generate a helm chart with some templatization options similar to the install render --template command. the PR also introduces a way to template the registry overrides option of the operator required by Azure/ARO-HCP#698 Signed-off-by: Gerd Oberlechner <[email protected]>
geoberle
added a commit
to geoberle/hypershift
that referenced
this pull request
Oct 24, 2024
Introduce a install helm command to generate a helm chart with some templatization options similar to the install render --template command. the PR also introduces a way to template the registry overrides option of the operator required by Azure/ARO-HCP#698 Signed-off-by: Gerd Oberlechner <[email protected]>
geoberle
added a commit
to geoberle/hypershift
that referenced
this pull request
Oct 25, 2024
Introduce a install helm command to generate a helm chart with some templatization options similar to the install render --template command. the PR also introduces a way to template the registry overrides option of the operator required by Azure/ARO-HCP#698 Signed-off-by: Gerd Oberlechner <[email protected]>
geoberle
force-pushed
the
hypershift-helm
branch
from
2485c24 to
9711e47
Compare
|
Please rebase pull request. |
geoberle
force-pushed
the
hypershift-helm
branch
from
9711e47 to
e2adb4a
Compare
geoberle
force-pushed
the
hypershift-helm
branch
3 times, most recently
from
8d9b958 to
d02dcfc
Compare
geoberle
requested review from
SudoBrendan,
UlrichSchlueter,
bennerv,
janboll,
jharrington22,
jmelis,
jonathan34c,
niontive,
nwnt,
weinong,
whober0521 and
zgalor
as code owners
tony-schndr
reviewed
Nov 6, 2024
Collaborator
tony-schndr
left a comment
tony-schndr
left a comment
There was a problem hiding this comment.
overall LGTM, just a few nits/questions.
hypershiftoperator/deploy/helm/charts/external-dns/templates/deployment-external-dns.yaml
Outdated
Show resolved
Hide resolved
|
Please rebase pull request. |
tony-schndr
reviewed
Nov 7, 2024
Collaborator
|
When deploying this the servicemonitor is created under the wrong group, should be |
geoberle
force-pushed
the
hypershift-helm
branch
from
94e3591 to
3cc2462
Compare
geoberle
force-pushed
the
hypershift-helm
branch
from
3cc2462 to
95d26c5
Compare
Collaborator
Author
we can't avoid that hypershift installs the |
tony-schndr
previously approved these changes
Nov 12, 2024
Signed-off-by: Gerd Oberlechner <[email protected]>
geoberle
force-pushed
the
hypershift-helm
branch
from
95d26c5 to
1d7194a
Compare
katherinelc321
pushed a commit
to katherinelc321/ARO-HCP
that referenced
this pull request
Jan 30, 2025
leverage helm chart for hypershift install/upgrade Signed-off-by: Gerd Oberlechner <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
use native
hypershift installfunctionality within helm chartthe external DNS part is still part of this helm chart. will be removed during P3.
Jira: https://issues.redhat.com/browse/ARO-11084
Link to demo recording:
Special notes for your reviewer