Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm chart for hypershift #698

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

helm chart for hypershift #698

wants to merge 2 commits into from
+312 −70,198

Conversation

geoberle
Copy link
Collaborator

@geoberle geoberle commented Oct 9, 2024 •
edited
Loading

What this PR does

use native hypershift install functionality within helm chart
the external DNS part is still part of this helm chart. will be removed during P3.

Jira: https://issues.redhat.com/browse/ARO-11084
Link to demo recording:

Special notes for your reviewer

@geoberle geoberle mentioned this pull request Oct 9, 2024
Merged
4 tasks
geoberle added a commit to geoberle/hypershift that referenced this pull request Oct 13, 2024
@geoberle
helm chart install option
b4741bf 
Introduce a install helm command to generate a helm chart with some templatization options similar to the install render --template command.

the PR also introduces a way to template the registry overrides option of the operator

required by Azure/ARO-HCP#698

Signed-off-by: Gerd Oberlechner <[email protected]>
geoberle added a commit to geoberle/hypershift that referenced this pull request Oct 17, 2024
@geoberle
helm chart install option
5d8b14a 
Introduce a install helm command to generate a helm chart with some templatization options similar to the install render --template command.

the PR also introduces a way to template the registry overrides option of the operator

required by Azure/ARO-HCP#698

Signed-off-by: Gerd Oberlechner <[email protected]>
geoberle added a commit to geoberle/hypershift that referenced this pull request Oct 18, 2024
@geoberle
helm chart install option
cc4d3ae 
Introduce a install helm command to generate a helm chart with some templatization options similar to the install render --template command.

the PR also introduces a way to template the registry overrides option of the operator

required by Azure/ARO-HCP#698

Signed-off-by: Gerd Oberlechner <[email protected]>
geoberle added a commit to geoberle/hypershift that referenced this pull request Oct 24, 2024
@geoberle
helm chart install option
f397009 
Introduce a install helm command to generate a helm chart with some templatization options similar to the install render --template command.

the PR also introduces a way to template the registry overrides option of the operator

required by Azure/ARO-HCP#698

Signed-off-by: Gerd Oberlechner <[email protected]>
geoberle added a commit to geoberle/hypershift that referenced this pull request Oct 25, 2024
@geoberle
helm chart install option
ec9559e 
Introduce a install helm command to generate a helm chart with some templatization options similar to the install render --template command.

the PR also introduces a way to template the registry overrides option of the operator

required by Azure/ARO-HCP#698

Signed-off-by: Gerd Oberlechner <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

Please rebase pull request.

@geoberle geoberle force-pushed the hypershift-helm branch 2 times, most recently from 7027b31 to 8d9b958 Compare November 6, 2024 08:18
@geoberle geoberle marked this pull request as ready for review November 6, 2024 08:58
tony-schndr
tony-schndr reviewed Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@tony-schndr tony-schndr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM, just a few nits/questions.

config/public-cloud-personal-dev.json
@@ -14,14 +14,17 @@
"cxKeyVaultPrivate": false,
"cxKeyVaultSoftDelete": false,
"externalDNSImageTag": "v0.14.2",
"externalDNSManagedIdentityName": "external-dns",
"externalDNSServiceAccountName": "external-dns",
"firstPartyAppClientId": "57e54810-3138-4f38-bd3b-29cb33f4c358",
"frontendCosmosDBDeploy": true,
"frontendCosmosDBDisableLocalAuth": true,
"frontendCosmosDBName": "aro-hcp-rp-76fc6",
"globalRG": "global",
"grafanaAdminGroupPrincipalId": "6b6d3adf-8476-4727-9812-20ffdef2b85c",
"grafanaName": "aro-hcp-grafana-76fc6",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for committing the .json files? The personal-dev.json seems to have generated config specific to someones personal account, for example the grafanaName field.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to force people to review the effect a change on config.yaml has. really no other reason as these files are not used for anything else.

hypershiftoperator/deploy/helm/Chart.yaml Outdated Show resolved Hide resolved
hypershiftoperator/deploy/helm/charts/external-dns/templates/deployment-external-dns.yaml Outdated Show resolved Hide resolved
hypershiftoperator/deploy/helm/templates/installer.job.yaml Outdated Show resolved Hide resolved
hypershiftoperator/deploy/helm/templates/installer.job.yaml Outdated Show resolved Hide resolved
@geoberle
typos
94e3591 
Signed-off-by: Gerd Oberlechner <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Please rebase pull request.

tony-schndr
tony-schndr reviewed Nov 7, 2024
View reviewed changes
hypershiftoperator/Makefile
helm upgrade --install hypershift deploy/helm \
--create-namespace --namespace ${HYPERSHIFT_NAMESPACE} \
--set image=${HO_IMAGE_BASE} \
--set imagetag=${HO_IMAGE_TAG} \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is imageTag in values.yaml

hypershiftoperator/Makefile
--set registryOverrides="quay.io/openshift-release-dev/ocp-v4.0-art-dev=${ARO_HCP_OCP_ACR}.azurecr.io/openshift/release\,quay.io/openshift-release-dev/ocp-release=${ARO_HCP_OCP_ACR}.azurecr.io/openshift/release-images\,registry.redhat.io/redhat=${ARO_HCP_OCP_ACR}.azurecr.io/redhat" \
--set azureKeyVaultClientId=$${CSI_SECRET_STORE_CLIENT_ID} \
--set external-dns.image=${ED_IMAGE_BASE} \
--set external-dns.imagetag=${ED_IMAGE_TAG} \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is imageTag in values.yaml

@tony-schndr
Copy link
Collaborator

When deploying this the servicemonitor is created under the wrong group, should be azmonitoring.coreos.com

kubectl get servicemonitor.monitoring.coreos.com -A
NAMESPACE                                                       NAME                                  AGE
hypershift                                                      operator                              18h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tony-schndr tony-schndr tony-schndr left review comments

@bennerv bennerv Awaiting requested review from bennerv bennerv is a code owner

@janboll janboll Awaiting requested review from janboll janboll is a code owner

@jmelis jmelis Awaiting requested review from jmelis jmelis is a code owner

@jonathan34c jonathan34c Awaiting requested review from jonathan34c jonathan34c is a code owner

@niontive niontive Awaiting requested review from niontive niontive is a code owner

@nwnt nwnt Awaiting requested review from nwnt nwnt is a code owner

@SudoBrendan SudoBrendan Awaiting requested review from SudoBrendan SudoBrendan is a code owner

@UlrichSchlueter UlrichSchlueter Awaiting requested review from UlrichSchlueter UlrichSchlueter is a code owner

@weinong weinong Awaiting requested review from weinong weinong is a code owner

@whober0521 whober0521 Awaiting requested review from whober0521 whober0521 is a code owner

@jharrington22 jharrington22 Awaiting requested review from jharrington22 jharrington22 is a code owner

@zgalor zgalor Awaiting requested review from zgalor zgalor is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geoberle @tony-schndr