oc-mirror configurability #775
Conversation
support configuration via environment variables instead of config file. this way deployment via azure container app should be more convenient Signed-off-by: Gerd Oberlechner <[email protected]>
geoberle
requested review from
bennerv,
janboll,
jmelis,
jonathan34c,
niontive,
nwnt,
SudoBrendan,
UlrichSchlueter,
weinong,
whober0521,
jharrington22 and
zgalor
as code owners
image-sync/oc-mirror/main.go
Outdated
| @@ -0,0 +1,62 @@ | |||
| package main | |||
There was a problem hiding this comment.
Nit: I not have used golang for this, but plain .sh, since it's available as well. 🤷♂️
There was a problem hiding this comment.
What about an alternative approach:
- Use tempaltize to generate the configuration
- Encode it base64, pass it in as environment variable
- Decode and write it to a file
There was a problem hiding this comment.
i like the base64 option. i'll go for it
Signed-off-by: Gerd Oberlechner <[email protected]>
| --set azureTenantId=$${TENANT_ID} \ | ||
| --set ocmirrorImage="arohcpdev.azurecr.io/image-sync/ocmirror" \ | ||
| --set ocmirrorTag=latest \ | ||
| --set credsPullSecret=pull-secret \ | ||
| --set credsKeyVaultName=service-kv-aro-hcp-dev | ||
| --set credsKeyVaultName=aro-hcp-dev-svc-kv |
| @@ -1,9 +1,9 @@ | |||
| FROM mcr.microsoft.com/cbl-mariner/base/core:2.0 AS downloader | |||
| FROM --platform=linux/amd64 mcr.microsoft.com/cbl-mariner/base/core:2.0 AS downloader | |||
There was a problem hiding this comment.
Do we need to specify platform here? Should the container infer it depending on the platform you run on?
| @@ -9,7 +9,6 @@ OC_MIRROR_IMAGE_TAGGED ?= $(OC_MIRROR_IMAGE):$(COMMIT) | |||
| build-push: image push | |||
|
|
|||
| image: | |||
| cp ../configuration/mvp-oc-mirror.yml config.yml | |||
| docker build --platform="linux/amd64" -f "./Dockerfile" -t ${OC_MIRROR_IMAGE_TAGGED} . | |||
There was a problem hiding this comment.
Docs say "podman" can we update docker -> podman or vice versa? Or do we have a preference?
| platform: | ||
| architectures: | ||
| - multi | ||
| - amd64 |
There was a problem hiding this comment.
Do we need amd64 images still, or can we switch everything to multi yet?
|
Please rebase pull request. |
|
closing this as it has been implemented as discussed in the #762 |
What this PR does
support configuration via environment variables instead of config file. this way deployment via azure container app should be more convenient
Jira:
Link to demo recording:
Special notes for your reviewer