-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move istio to svc cluster rollout #979
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan34c
force-pushed
the
jonachang/svc
branch
from
December 13, 2024 18:17
a2614b8
to
6c0f373
Compare
jonathan34c
requested review from
bennerv,
geoberle,
janboll,
weinong,
whober0521,
tony-schndr,
jmelis,
nwnt,
SudoBrendan and
UlrichSchlueter
as code owners
December 13, 2024 19:01
mociarain
previously approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* ensure tag exists - if not set it to the current version Signed-off-by: Gerd Oberlechner <[email protected]>
Signed-off-by: Gerd Oberlechner <[email protected]>
use the list of stale pods and group by owner, then process each owner and wait for finished rollout Signed-off-by: Gerd Oberlechner <[email protected]>
Signed-off-by: Gerd Oberlechner <[email protected]>
…on tag with the target version, iterate through pods and do the istio version maintainance. Created the istio.sh and run the shellscript after svc infra deployment pipeline. The shell script would make sure the istio service mesh in the cluster is in the right version. This commit added the istio shell script and merge the istio maintances as part of the svc deployment.
jonathan34c
force-pushed
the
jonachang/svc
branch
from
December 19, 2024 22:58
f173e69
to
3fa733b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Move istio from hcp to ARO-HCP. Will run istio sh in every svc deployment. But will only upgrade if there's new version
https://msazure.visualstudio.com/AzureRedHatOpenShift/_build/results?buildId=110334014&view=results
https://dev.azure.com/msazure/AzureRedHatOpenShift/_build/results?buildId=110608387&view=results
Jira:
Link to demo recording:
Special notes for your reviewer