Conversation
hlipsig
requested review from
bennerv,
cadenmarchese,
hawkowl,
jharrington22,
mrWinston,
rogbas and
yjst2012
as code owners
hlipsig
requested review from
alcasim,
kimorris27,
mociarain,
sankur-codes,
tiguelu,
tsatam,
tuxerrante,
ventifus and
wanghaoran1988
as code owners
tsatam
approved these changes
Mar 6, 2026
There was a problem hiding this comment.
Pull request overview
Removes the cluster quota monitor/collector that was not reliably emitting a metric and could panic in rare cases, reducing monitor noise and eliminating the observed panic path.
Changes:
- Delete the quota failure detection collector implementation and its associated metric constant/helpers.
- Remove the quota collector from the default
Monitorcollectors list. - Remove the unit test coverage specific to the deleted quota monitor logic.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/monitor/cluster/quota.go | Removes quota failure detection logic and metric emission. |
| pkg/monitor/cluster/quota_test.go | Removes tests for the deleted quota monitor behavior. |
| pkg/monitor/cluster/cluster.go | Drops the quota collector from the monitor’s collectors list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
komidore64
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… cases panicked
Which issue this PR addresses:
Fixes ARO-25071 and INT-00070
Fixes
What this PR does / why we need it:
Monic panic clued us in to the fact that this didn't emit a metric properly. For now we've decided to deprecate this and we'll reassess what the intent was as it wasn't in use for operations.
Test plan for issue:
Green e2e and monitor tests.
Is there any documentation that needs to be updated for this PR?
We were not using the metrics so no documentation updates.
How do you know this will function as expected in production?
Logs will clear of panics.