Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new workflow for scanning secrets in commits #10652

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Conversation

manishkumar1991
Copy link
Contributor

@manishkumar1991 manishkumar1991 commented Jun 13, 2024

Required items, please complete

Change(s):

  • Addition of new workflow for scanning secrets in commits

Reason for Change(s):

  • Prevent accidental credential leakage while committing code

Version Updated:

  • v1 yes

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • yes

Secret scanning When< continue-on-error: true> is used

Truffle hog able to identify the secrets but workflow ran successfully

image

image

Secret scanning when < continue-on-error: true> is not used

Truffle hog able to identify and workflow also failed

image

image

@manishkumar1991 manishkumar1991 requested review from a team as code owners June 13, 2024 09:12
anki-narravula
anki-narravula previously approved these changes Jun 21, 2024
@v-atulyadav v-atulyadav merged commit 80f7ca3 into master Jul 19, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants