Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fortinet FortiGate WebSession Parsers Parsing Fix & Additions #10865

Open
wants to merge 28 commits into
base: master
Choose a base branch
from

Conversation

t-pol
Copy link

@t-pol t-pol commented Jul 24, 2024

Required items, please complete

Change(s):

  • Update kql ASimWebSessionFortinetFortiGate.yaml
  • Update kql vimWebSessionFortinetFortiGate.yaml

Reason for Change(s):

  • When there is no User Agent string in AdditionalExtensions, the parsing of HttpRequestMethod fails.
    Incorrect parsing of HttpRequestMethod and HttpUserAgent.
    300977692-5147bab0-35b3-4861-9610-7e0ece0a3628

  • Adding NetworkApplicationProtocol field in the project-rename. (Optional field in the parser, but it exists in FortiGate logs)

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • No

@t-pol t-pol requested review from a team as code owners July 24, 2024 08:34
@t-pol
Copy link
Author

t-pol commented Jul 24, 2024

@microsoft-github-policy-service agree

@v-atulyadav
Copy link
Contributor

Hi @t-pol,
PR is having validation failures please check. Thanks

@v-atulyadav
Copy link
Contributor

Hi @t-pol,
Please investigate the failed validations. Thanks

@t-pol
Copy link
Author

t-pol commented Aug 2, 2024

The issues have been fixed. Thanks

@v-atulyadav
Copy link
Contributor

Thanks @t-pol.

@t-pol
Copy link
Author

t-pol commented Aug 13, 2024

Hello, is there any feedback regarding the parser ?

@Alekhya0824
Copy link
Contributor

can you please add tester files after testing
this is the documentation to add schema tester and data tester https://learn.microsoft.com/en-us/azure/sentinel/normalization-develop-parsers#test-parsers
These schema tester and data tester files can add under Tests files

@v-atulyadav
Copy link
Contributor

Hi @t-pol, please check above comments from @Alekhya0824 and act accordingly. Thanks

@v-atulyadav
Copy link
Contributor

Hi @t-pol,
Please respond on above asks. Thanks

@t-pol
Copy link
Author

t-pol commented Sep 10, 2024

Results of tests have been uploaded. Thanks

@v-atulyadav
Copy link
Contributor

Thanks @t-pol.

@t-pol
Copy link
Author

t-pol commented Oct 3, 2024

Hello, is there any feedback regarding the parser ?

@vakohl
Copy link
Contributor

vakohl commented Oct 7, 2024

hi @t-pol We have made some changes to our github validation script, can you please pull latest changes from upstream repo?

@t-pol
Copy link
Author

t-pol commented Oct 7, 2024

The changes have been merged.

@t-pol
Copy link
Author

t-pol commented Oct 18, 2024

Hello @vakohl , Is there any feedback regarding this ?

@vakohl
Copy link
Contributor

vakohl commented Oct 18, 2024

Hello @vakohl , Is there any feedback regarding this ?

Hi @t-pol , thanks for the change suggestion. We'll add the change you suggested along with few other minor corrections. Please see my comments

@v-atulyadav
Copy link
Contributor

Hi @t-pol,
Kindly review the comments provided by @vakohl above and take the necessary actions. Thanks

@v-atulyadav
Copy link
Contributor

Hi @t-pol,
I would appreciate it if you could assess the remarks made by @vakohl above and implement the necessary measures. Thanks

@vakohl
Copy link
Contributor

vakohl commented Nov 5, 2024

@t-pol Can you please help attaching sample data for the parser? You can anonymize data before uploading

@vakohl
Copy link
Contributor

vakohl commented Nov 5, 2024

@t-pol Can you please help attaching sample data for the parser? You can anonymize data before uploading

Validations are failing due to this

image

@v-atulyadav
Copy link
Contributor

Hi @t-pol,
We are looking forward to receiving an update on this PR. Thanks

@v-atulyadav
Copy link
Contributor

Hi @t-pol,
We are keen to hear any updates concerning this PR. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants