Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Data Connector code with fix of jsondecoder error and upgraded python version from 3.9 to 3.11 for BitSight #11177

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Updated Data Connector code with fix of jsondecoder error and upgraded python version from 3.9 to 3.11 for BitSight #11177

merged 3 commits into from
Oct 7, 2024

Conversation

niralishah-crest
Copy link
Contributor

Change(s):

  • Updated Data Connector code.
  • Upgrade python version from 3.9 to 3.11

Reason for Change(s):

  • to fix checkpoint file corruption issue

Version Updated:

  • No

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

@niralishah-crest niralishah-crest changed the title Updated Data Connector code with fix of currpted checkpoint file and upgraded python version from 3.9 to 3.11 Updated Data Connector code with fix of corrupted checkpoint file and upgraded python version from 3.9 to 3.11 for BitSight Sep 24, 2024
@v-prasadboke v-prasadboke added Connector Connector specialty review needed Solution Solution specialty review needed labels Sep 25, 2024
@niralishah-crest
Copy link
Contributor Author

@v-shukore Any update on this PR review?

@v-shukore
Copy link
Contributor

Hi @niralishah-crest,
As per your PR title, please update the checkpoint solution files. Currently, you have only updated the BitSight solution files. Our team has made changes to the checkpoint solution, so please refer to this PR for your reference.
#11137
Also, update the version to 3.11 in the BitSight_API_FunctionApp.json file and repackage the solution.

@niralishah-crest niralishah-crest changed the title Updated Data Connector code with fix of corrupted checkpoint file and upgraded python version from 3.9 to 3.11 for BitSight Updated Data Connector code with fix of jsondecoder error and upgraded python version from 3.9 to 3.11 for BitSight Oct 4, 2024
@niralishah-crest
Copy link
Contributor Author

niralishah-crest commented Oct 4, 2024 •
edited
Loading

@v-shukore This PR is regarding changes done to fix jsondecoder error in BitSight Solution which we have developed earlier. So we have updated files for BitSight Data Connector.
Regarding python version, we have add python packages of 3.11 in Data Connector zip and also updated version in azuredeploy_BitSight_API_FunctionApp.json file

@v-shukore
Copy link
Contributor

Hi @niralishah-crest, please share the success running data connector screenshot with us. Thanks..!!

@niralishah-crest
Copy link
Contributor Author

@v-shukore Please find the SS for running function app invocations.
image
image
image

@v-atulyadav v-atulyadav merged commit 29f47b0 into Azure:master Oct 7, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-shukore v-shukore v-shukore approved these changes

@v-atulyadav v-atulyadav v-atulyadav approved these changes

Assignees

@v-shukore v-shukore

Labels
Connector Connector specialty review needed Solution Solution specialty review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@niralishah-crest @v-shukore @v-atulyadav @v-prasadboke