Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cisco Meraki via REST API configurationChanges pagination fix #11195

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Cisco Meraki via REST API configurationChanges pagination fix #11195

merged 3 commits into from
Sep 30, 2024

Conversation

alfeldsh
Copy link
Member

@alfeldsh alfeldsh commented Sep 29, 2024 •
edited
Loading

Required items, please complete

Change(s):

  • Updated Cisco Meraki via REST API request pagination to use previous link instead of next

Reason for Change(s):

  • Bug in Cisco Meraki pagination causing an infinite loop when polling for configuration changes

Version Updated:

  • Yes, updated solution version from 3.0.0 to 3.0.1

Testing Completed:

  • Yes, installed the solution and validate the changes.

Checked that the validations are passing and have addressed any issues that are present:

  • KQL validation are not relevant to the PR

@alfeldsh alfeldsh marked this pull request as ready for review September 29, 2024 14:36
@alfeldsh alfeldsh requested review from a team as code owners September 29, 2024 14:36
@v-atulyadav v-atulyadav added Connector Connector specialty review needed Solution Solution specialty review needed labels Sep 30, 2024
v-shukore
v-shukore previously approved these changes Sep 30, 2024
View reviewed changes
v-atulyadav
v-atulyadav previously approved these changes Sep 30, 2024
View reviewed changes
@v-shukore v-shukore dismissed stale reviews from v-atulyadav and themself via 4c21a46 September 30, 2024 07:32
@v-atulyadav v-atulyadav merged commit 3eb2fb4 into Azure:master Sep 30, 2024
32 checks passed
@JustinGrote JustinGrote mentioned this pull request Oct 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-atulyadav v-atulyadav v-atulyadav approved these changes

@v-shukore v-shukore v-shukore left review comments

Assignees

@v-shukore v-shukore

Labels
Connector Connector specialty review needed Solution Solution specialty review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alfeldsh @v-atulyadav @v-shukore