Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recorded future solution update #11203

Merged
merged 20 commits into from
Oct 11, 2024

Conversation

ErikMangstenRecFut
Copy link
Contributor

Required items, please complete

Change(s):

  • README updates for multiple playbooks
  • RecordedFuture-IOC_Enrichment: Added protocol check for URL enrichments
  • RecordedFuture-CustomConnector: Moved parameters from important to internal and advanced

Reason for Change(s):

  • Improved the install and troubleshooting experience for users
  • Remove common error that URL protocol was missing for URL enrichments

Testing Completed:

  • Yes

@ErikMangstenRecFut
Copy link
Contributor Author

ErikMangstenRecFut commented Oct 1, 2024

@microsoft-github-policy-service agree company="Recorded Future"

1 similar comment
@ErikMangstenRecFut
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Recorded Future"

@v-atulyadav v-atulyadav added the Solution Solution specialty review needed label Oct 1, 2024
@v-shukore
Copy link
Contributor

Hi @ErikMangstenRecFut,
this solution is not repackaged correctly in this template. The analytic rules are missing, so please repackage this solution again using the V3 tool and commit the changes.

I tried to commit the changes, but I don't have access to this branch. Could you please grant me access to this branch so I can commit the changes.
Thanks...!!

@ErikMangstenRecFut
Copy link
Contributor Author

Hi @v-shukore,
Strange, I ran the script located at Tools/Create-Azure-Sentinel-Solution/V3/createSolutionV3.ps1 in the repo. Might it have something to do with the fact that I'm on Mac OS? Anyway, I have added you as a collaborator to our fork, so you should now be able to commit to it.

@v-atulyadav v-atulyadav merged commit 8954be5 into Azure:master Oct 11, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants