Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update azuredeploy_MimecastSEG_AzureFunctionApp.json #11367

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Update azuredeploy_MimecastSEG_AzureFunctionApp.json #11367

merged 1 commit into from
Nov 6, 2024

Conversation

JimReprogle
Copy link
Contributor

@JimReprogle JimReprogle commented Oct 30, 2024 •
edited
Loading

Change(s):

  • Create a parameter for hostingPlan, instead of using the appName for it.

Reason for Change(s):

  • It helps resolve errors when the app service plan doesn't exist, and you get quota errors which are misleading.
  • Rather than making an erroneous assumption, we just ask the user for the plan name.

Testing completed:

  • Implemented the same template in Sentinel and it works.

@JimReprogle
Update azuredeploy_MimecastSEG_AzureFunctionApp.json
9dbf44f 
Rather than using the appName for the hostingPlanName, we ask the user for it. It helps resolve errors when the app service plan doesn't exist, and you get quota errors which are misleading.
@JimReprogle JimReprogle requested review from a team as code owners October 30, 2024 19:23
@v-prasadboke v-prasadboke self-assigned this Nov 4, 2024
@v-prasadboke v-prasadboke added the Connector Connector specialty review needed label Nov 4, 2024
@v-prasadboke v-prasadboke merged commit a2edfa4 into Azure:master Nov 6, 2024
31 checks passed
@JimReprogle JimReprogle deleted the patch-1 branch November 6, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-prasadboke v-prasadboke v-prasadboke approved these changes

Assignees

@v-prasadboke v-prasadboke

Labels
Connector Connector specialty review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JimReprogle @v-prasadboke