Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Bicep CI bootstrap tool and docs to support OIDC #1809

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Update Bicep CI bootstrap tool and docs to support OIDC #1809

merged 3 commits into from
Jan 24, 2025

Conversation

jtracey93
Copy link
Contributor

@jtracey93 jtracey93 commented Jan 23, 2025 •
edited by azure-boards bot
Loading

Overview/Summary

Update Bicep CI bootstrap tool and docs to support OIDC

This PR fixes/adds/changes/removes

  1. Update Bicep CI bootstrap tool and docs to support OIDC
  2. AB#39011

Test Evidence

https://github.com/jtracey93/bicep-registry-modules/actions/runs/12931754663

image
image

Breaking Changes

PowerShell Bicep Bootstrap tool now defaults to OIDC (technically breaking, but its a run once tool)

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@jtracey93 jtracey93 added Type: Documentation 📄 Improvements or additions to documentation Type: Feature Request ➕ New feature or request labels Jan 23, 2025
@jtracey93 jtracey93 requested a review from a team as a code owner January 23, 2025 16:22
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Jan 23, 2025
@jtracey93 jtracey93 requested a review from eriqua January 23, 2025 17:13
eriqua
eriqua approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@jtracey93 jtracey93 merged commit 92f514b into main Jan 24, 2025
4 checks passed
@jtracey93 jtracey93 deleted the users/jtracey93/feat/update-bicep-controbutor-bootstrap-oidc branch January 24, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@jtracey93 jtracey93

@eriqua eriqua

Labels
Needs: Triage 🔍 Maintainers need to triage still Type: Documentation 📄 Improvements or additions to documentation Type: Feature Request ➕ New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtracey93 @eriqua