Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add toggle workflow description #377

Merged
merged 16 commits into from
Jan 2, 2024

Conversation

rahalan
Copy link
Contributor

@rahalan rahalan commented Dec 5, 2023

Add documentation to AVM how to use the toggle worklow

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Dec 5, 2023
@matebarabas matebarabas added Type: Documentation 📄 Improvements or additions to documentation and removed Needs: Triage 🔍 Maintainers need to triage still labels Dec 6, 2023
@eriqua eriqua changed the title add toggle workflow description feat: add toggle workflow description Dec 11, 2023
rahalan and others added 9 commits December 18, 2023 16:12
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great in content @rahalan. Could you please have a look at linter issues raised by the PR checks?

@rahalan
Copy link
Contributor Author

rahalan commented Dec 21, 2023

Looks great in content @rahalan. Could you please have a look at linter issues raised by the PR checks?

@eriqua fixed, except one: having a heading at the beginning. The other files in the same hierarchy level also don't have one

@eriqua eriqua self-requested a review December 23, 2023 12:44
eriqua
eriqua previously approved these changes Dec 23, 2023
@eriqua eriqua dismissed their stale review December 23, 2023 12:46

Clarify if approving with linter errors

@eriqua
Copy link
Contributor

eriqua commented Dec 23, 2023

Looks great in content @rahalan. Could you please have a look at linter issues raised by the PR checks?

@eriqua fixed, except one: having a heading at the beginning. The other files in the same hierarchy level also don't have one

@rahalan @AlexanderSehr this looks good to me, but I don't remember what was decided around this linter check. Are we waiting for a linter fix that would skip this control? Should we merge nevertheless?

@AlexanderSehr
Copy link
Contributor

Looks great in content @rahalan. Could you please have a look at linter issues raised by the PR checks?

@eriqua fixed, except one: having a heading at the beginning. The other files in the same hierarchy level also don't have one

@rahalan @AlexanderSehr this looks good to me, but I don't remember what was decided around this linter check. Are we waiting for a linter fix that would skip this control? Should we merge nevertheless?

If I'm not mistaken, @rahalan was supposed to add an exception for this rule to the linter config file

@rahalan
Copy link
Contributor Author

rahalan commented Dec 28, 2023

Looks great in content @rahalan. Could you please have a look at linter issues raised by the PR checks?

@eriqua fixed, except one: having a heading at the beginning. The other files in the same hierarchy level also don't have one

@rahalan @AlexanderSehr this looks good to me, but I don't remember what was decided around this linter check. Are we waiting for a linter fix that would skip this control? Should we merge nevertheless?

If I'm not mistaken, @rahalan was supposed to add an exception for this rule to the linter config file

Done

@AlexanderSehr
Copy link
Contributor

AlexanderSehr commented Dec 28, 2023

There seems to be one issue left with a missing empty line at the end of a markdown (see logs)

@rahalan
Copy link
Contributor Author

rahalan commented Jan 2, 2024

There seems to be one issue left with a missing empty line at the end of a markdown (see logs)

@AlexanderSehr fixed

@rahalan rahalan merged commit 7a83a97 into Azure:main Jan 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation 📄 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants