Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap 5.3.0 #551

Merged
merged 11 commits into from
Dec 19, 2023
Merged

Bootstrap 5.3.0 #551

merged 11 commits into from
Dec 19, 2023

Conversation

neelavarshad
Copy link
Contributor

Changed bootstrap version from 4.4.1 to 5.3.0

Review deployment and check all flows

@neelavarshad neelavarshad self-assigned this Sep 18, 2023
santhoshb-msft
santhoshb-msft requested changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@santhoshb-msft santhoshb-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @neelavarshad could you merge latest from main and resolve conflicts

@neelavarshad
Copy link
Contributor Author

@santhoshb-msft Merged and resolved

@santhoshb-msft
Copy link
Contributor

@santhoshb-msft Merged and resolved

Thank you @neelavarshad

@santhoshb-msft
Copy link
Contributor

@neelavarshad some initial observations below

Admin page issues:

  • Logo
  • Menu notworking when minimized
  • buttons alignment to right (details/activate page)
  • Plans page tabs not working
  • Email templates action not working
  • Appsettings button gap
  • Cookies title
  • Fetch all moved
  • Table alignment
  • Offer page - space on the top.
  • App config action not working.

Landing page: Yet to test

@santhoshb-msft santhoshb-msft linked an issue Oct 13, 2023 that may be closed by this pull request
Bootstrap 5.0 update #571
Closed
@neelavarshad
Copy link
Contributor Author

neelavarshad commented Oct 19, 2023 •
edited
Loading

  • - Logo
  • - Menu notworking when minimized
  • - buttons alignment to right (details/activate page)
  • - Plans page tabs not working
  • - Email templates action not working
  • - Appsettings button gap
  • - Cookies title
  • - Fetch all moved
  • - Table alignment
  • - Offer page - space on the top.
  • - App config action not working.

More fixes:

  • Removed underline from links on app config
  • Added breakline at logo upload

@neelavarshad
Copy link
Contributor Author

neelavarshad commented Oct 19, 2023 •
edited
Loading

Menu not working when minimized - OK
image

@santhoshb-msft santhoshb-msft self-assigned this Nov 3, 2023
santhoshb-msft
santhoshb-msft requested changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@santhoshb-msft santhoshb-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neelavarshad almost looks good with some imperfections in the UI which I will share directly with you. things like alignment and some button functionalities.

@santhoshb-msft santhoshb-msft removed their assignment Nov 10, 2023
@santhoshb-msft
Copy link
Contributor

@neelavarshad once you are done with the changes, please assign the PR to me

@neelavarshad
Copy link
Contributor Author

@santhoshb-msft Assigned the PR back to you.
I have changed the UI per your comments. There was a missing screenshot for Change quantity, but I think you meant to showcase left alignment. I have made that change but let me know if there's anything else. Thanks!

santhoshb-msft
santhoshb-msft reviewed Dec 15, 2023
View reviewed changes
Copy link
Contributor

@santhoshb-msft santhoshb-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of code comments below and some ui changes suggested on the internal chat

src/CustomerSite/CustomerSite.csproj Show resolved Hide resolved
@santhoshb-msft santhoshb-msft removed their assignment Dec 15, 2023
@neelavarshad
Copy link
Contributor Author

@santhoshb-msft Pushed additional changes and assigned back to you. Thanks!

santhoshb-msft
santhoshb-msft reviewed Dec 19, 2023
View reviewed changes
Copy link
Contributor

@santhoshb-msft santhoshb-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment inline

src/AdminSite/Views/Shared/_Layout.cshtml Outdated Show resolved Hide resolved
@neelavarshad
Copy link
Contributor Author

Changes to landing page with Change quantity button added.

santhoshb-msft
santhoshb-msft approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@santhoshb-msft santhoshb-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with new installation and upgrade scenarios.
All commented fixed by @neelavarshad

Approving

@santhoshb-msft santhoshb-msft merged commit 837a5e5 into main Dec 19, 2023
7 checks passed
@santhoshb-msft santhoshb-msft deleted the neela-bs-01 branch September 13, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santhoshb-msft santhoshb-msft santhoshb-msft approved these changes

@code4clouds code4clouds Awaiting requested review from code4clouds

@msalemcode msalemcode Awaiting requested review from msalemcode

Assignees

@santhoshb-msft santhoshb-msft

@neelavarshad neelavarshad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bootstrap 5.0 update
2 participants
@neelavarshad @santhoshb-msft