Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workload Specific Compliance Update #1947

Merged
merged 12 commits into from
Mar 21, 2025
Merged

Conversation

Springstone
Copy link
Member

Overview/Summary

This pull request involves multiple changes to the eslzArm/eslz-portal.json file, primarily focused on updating the default values and labels for various policy initiatives to ensure better compliance tracking and enforcement.

Key changes include:

  • Policy Descriptions:

    • Updated the description text in the Microsoft.Common.InfoBox to provide clearer distinctions between "Enforce," "Audit only," and "Disabled" policies.
  • Default Values and Labels:

Azure Public

Deploy To Azure

@Springstone Springstone requested a review from a team as a code owner March 12, 2025 15:36
Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Springstone, thanks for making these changes. I left one comment on a toolTip, but this applies to multiple. Can you review and update the toolTip’s to align with the new label names?

Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Springstone while reviewing a deployment, I noticed that some initiatives use default values even though I set it to Audit only.

Enforce recommended guardrails for Bot Service:

image

Enforce recommended guardrails for Cognitive Services:

image

Can you review?

Edit - missed the enforcement mode setting. All good.

Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjenhuitema arjenhuitema merged commit ae7da9c into Azure:main Mar 21, 2025
4 checks passed
@Springstone Springstone deleted the WSCUpdate branch March 26, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants