-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workload Specific Compliance Update #1947
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Springstone, thanks for making these changes. I left one comment on a toolTip, but this applies to multiple. Can you review and update the toolTip’s to align with the new label names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Springstone while reviewing a deployment, I noticed that some initiatives use default values even though I set it to Audit only.
Enforce recommended guardrails for Bot Service:
Enforce recommended guardrails for Cognitive Services:
Can you review?
Edit - missed the enforcement mode setting. All good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Overview/Summary
This pull request involves multiple changes to the
eslzArm/eslz-portal.json
file, primarily focused on updating the default values and labels for various policy initiatives to ensure better compliance tracking and enforcement.Key changes include:
Policy Descriptions:
Microsoft.Common.InfoBox
to provide clearer distinctions between "Enforce," "Audit only," and "Disabled" policies.Default Values and Labels:
defaultValue
for multiple policy initiatives from "No" to "Audit only" to ensure that non-compliant actions are logged by default. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]allowedValues
labels for policy initiatives to "Enforce," "Audit only," and "Disabled" for better clarity and consistency. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]Azure Public