Update Enforce-Guardrails-KeyVault.json

[arrerezai]

It's called Hardware Security Module, hence HSM (and not HMS).

[Springstone]

Thanks for contributing. However, there are some additional changes needed. Please increment the minor version of the initiative (https://github.com/Azure/Enterprise-Scale/wiki/ALZ-Policies#versioning). Kindly also run the build process to include the changes (https://github.com/Azure/Enterprise-Scale/wiki/Whats-new#august-2024). And as always, please include a description of what has been changed in the WhatsNew.md.

[arrerezai]

Hi @Springstone,
Bumping the minor version was easily achieved but running the build process is much more difficult due to the initiatives.bicep not being present in the file location suggested by the wiki link you shared with me (i.e. the WhatsNew.md section from Aug 2024). Moreover, I find it even more difficult to understand what needs to be done with the json file post running the build script? I think such small change like this one shouldn't have too many barriers to pass as it only corrects what was wrong in the first place. If you find the change accurate, please approve it. If not, let me know in more detail what needs to be done for someone that would like to contribute to this project for the very first time. Thanks!

[Springstone]

Hi @Springstone, Bumping the minor version was easily achieved but running the build process is much more difficult due to the initiatives.bicep not being present in the file location suggested by the wiki link you shared with me (i.e. the WhatsNew.md section from Aug 2024). Moreover, I find it even more difficult to understand what needs to be done with the json file post running the build script? I think such small change like this one shouldn't have too many barriers to pass as it only corrects what was wrong in the first place. If you find the change accurate, please approve it. If not, let me know in more detail what needs to be done for someone that would like to contribute to this project for the very first time. Thanks!

Hi @arrerezai, thanks for following up. ALZ policies and initiatives in this repository are deployed as a single payload, which is generated using bicep (otherwise it would take hours to deploy). In this case, since you've made a change to an initiative, we need to rebuild the initiative payload:

bicep build ./src/templates/initiatives.bicep --outfile ./eslzArm/managementGroupTemplates/policyDefinitions/initiatives.json

This command should be run from the root folder of the cloned repository and assumes you have bicep installed. Both those files currently exist in the repository, but we need to rebuild the initiatives.json file so that it includes your update. Once done, you should have a new file to check in, the initiatives.json.

I hope this clarifies, let me know if you have any more questions.

[jtracey93]

closing as will do in #2105