feat(vscode): Logic App and Workflows As Menu Items #6310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… items. Removed ability to create logic app outside of a workspace. Refactored to utilize common methods and reduce duplication
…e is opened for full functionality
There was a problem hiding this comment.
Copilot reviewed 6 out of 21 changed files in this pull request and generated no comments.
Files not reviewed (15)
- apps/vs-code-designer/src/app/commands/createNewCodeProject/createCodeProjectSteps/createLogicApp/ScriptProjectCreateStep.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/ProjectCodeCreateStepBase.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewProject/createProjectSteps/ExistingWorkspaceStep.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewProject/createNewProject.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/createNewCodeProject.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/SetWorkspaceName.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/SetWorkspaceSettings.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/WorkflowCodeProjectCreateStep.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/createCodeProjectSteps/createFunction/InvokeFunctionProjectSetup.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/OpenFolderStepCodeProject.ts: Evaluated as low risk
- apps/vs-code-designer/src/main.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewProject/createProjectSteps/ProjectCreateStepBase.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/NewCodeProjectTypeStep.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewProject/createProjectSteps/ScriptProjectCreateStep.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/SetLogicAppNameStep.ts: Evaluated as low risk
…nction method names inside a workspace, moved convert to workspace
…ions.json file, corrected path to create .vscode folder, and updated OpenFolder to not add the .code-workspace file to the workspace folders.
…schema type in isLogicAppProject. Improved prompt to only display the folders that contain a logic app project, not all folders in the workspace.
… logic apps with possibly the same workflow names
…if the menu was initiated outside of highlighted logic app in the workspace
…rianmsft/LogicAppsUX into logic_app_and_workflow_menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved creation of new logic app and new workflows as right click menu items. Removed ability to create logic app outside of a workspace. Refactored to utilize common methods and reduce duplication
Requirement Checklist
Type of Change
Current Behavior
Currently customers can create logic app projects without a workspace as well as add new logic app projects and workflows by going to the Azure icon and clicking on the Logic Apps icon as shown. Custom code and rules engine projects have the logic app created as LogicApp and the functions under Function folder as default.
New Behavior
Customers will now be unable to create logic apps outside of a workspace. Customers will now be required to create a logic app workspace that holds their logic app project. Customers will now be able to add new logic app projects and workflows to their workspace by using the right click menu and selecting the appropriate option.
Custom code and rules engine projects now have a logic app name prompt instead of defaulting to LogicApp and the Functions folder is now removed and renamed to the name of the function the user created.
Impact of Change
See the new behavior section.
Screenshots or Videos (if applicable)