Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connectedmachine] release preview version 2024-07-31 #8214

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

yaotongms
Copy link
Member

@yaotongms yaotongms commented Oct 30, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Oct 30, 2024

❌Azure CLI Extensions Breaking Change Test
❌connectedmachine
rule cmd_name rule_message suggest_message
1002 - CmdRemove connectedmachine private-link-scope update-tag cmd connectedmachine private-link-scope update-tag removed please confirm cmd connectedmachine private-link-scope update-tag removed
⚠️ 1011 - SubgroupAdd connectedmachine license-profile sub group connectedmachine license-profile added
⚠️ 1011 - SubgroupAdd connectedmachine run-command sub group connectedmachine run-command added

Copy link

Hi @yaotongms,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @yaotongms,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 30, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Oct 30, 2024

Hi @yaotongms

⚠️ Release Requirements

Module: connectedmachine

  • ⚠️ Please update VERSION to be 2.0.0 in src/connectedmachine/setup.py
  • ⚠️ Remove azext.isPreview: true in azext_metadata.json for connectedmachine

Module: test

  • ⚠️ Remove azext.isPreview: true in azext_metadata.json for test

Notes

@yonzhan yonzhan requested a review from kairu-ms October 30, 2024 22:59
@yonzhan yonzhan assigned kairu-ms and unassigned zhoxing-ms Oct 30, 2024
@yonzhan yonzhan requested a review from jsntcy October 30, 2024 22:59
@kairu-ms
Copy link
Contributor

kairu-ms commented Nov 5, 2024

please record tests again to update recording files

@kairu-ms
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms
Copy link
Contributor

kairu-ms commented Nov 12, 2024

Please fix the code issue

ValueError: The operation 'azext_connectedmachine.custom#connectedmachine_private_link_scope_update_tag' is invalid.

If you want to release, please update the extension version.

@yaotongms yaotongms removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 13, 2024
@yaotongms
Copy link
Member Author

Azure/aaz#625

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 14, 2024
@yaotongms yaotongms removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 14, 2024
@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 14, 2024
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 15, 2024
@necusjz
Copy link
Member

necusjz commented Nov 15, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@yaotongms
Copy link
Member Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 8214 in repo Azure/azure-cli-extensions

@necusjz
Copy link
Member

necusjz commented Nov 15, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link

Commenter does not have sufficient privileges for PR 8214 in repo Azure/azure-cli-extensions

@necusjz
Copy link
Member

necusjz commented Nov 15, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz
Copy link
Member

necusjz commented Nov 15, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz
Copy link
Member

necusjz commented Nov 18, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants