ci: Populate missing fields in CNS configmap #3503
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR populates missing fields in various CNS configmaps used for integration testing in Azure Container Networking. The changes add additional configuration keys to ensure a more complete set of fields across different manifest files.
- Added "EnableStateMigration": false, "EnableSubnetScarcity": false, and "MetricsBindAddress": ":10092" to multiple configmaps.
- Some Windows-specific configmaps receive only a subset of these new fields.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/integration/manifests/cnsconfig/overlayconfigmap.yaml | Added three new keys to the overlay config. |
| test/integration/manifests/cnsconfig/swiftlinuxconfigmap.yaml | Added three new keys to the Swift Linux config. |
| test/integration/manifests/cnsconfig/swiftwindowsconfigmap.yaml | Added three new keys to the Swift Windows config. |
| test/integration/manifests/cnsconfig/azurecnioverlaylinuxconfigmap.yaml | Added three new keys to the Azure CNI overlay Linux config. |
| test/integration/manifests/cnsconfig/ciliumnodesubnetconfigmap.yaml | Added three new keys to the Cilium Node Subnet config. |
| test/integration/manifests/cnsconfig/ciliumconfigmap.yaml | Added three new keys to the Cilium config. |
| test/integration/manifests/cnsconfig/azurecnidualstackoverlaylinuxconfigmap.yaml | Added three new keys to the dual-stack overlay Linux config. |
| test/integration/manifests/cnsconfig/azurestatelesscnioverlaywindowsconfigmap.yaml | Added two new keys – missing "EnableSubnetScarcity". |
| test/integration/manifests/cnsconfig/azurecnioverlaywindowsconfigmap.yaml | Added only one new key. |
| test/integration/manifests/cnsconfig/azurecnidualstackoverlaywindowsconfigmap.yaml | Added only one new key. |
Comments suppressed due to low confidence (3)
test/integration/manifests/cnsconfig/azurestatelesscnioverlaywindowsconfigmap.yaml:35
- The addition of new fields in this configmap is inconsistent with similar files (e.g., Swift Windows) which include 'EnableSubnetScarcity'. Consider adding "EnableSubnetScarcity": false for consistency across Windows configmaps.
"MetricsBindAddress": ":10092",
test/integration/manifests/cnsconfig/azurecnioverlaywindowsconfigmap.yaml:34
- Only 'EnableStateMigration' is added here whereas other similar Windows configmaps include additional fields such as "EnableSubnetScarcity" and "MetricsBindAddress". Review whether these fields should be added for consistency.
"EnableStateMigration": false,
test/integration/manifests/cnsconfig/azurecnidualstackoverlaywindowsconfigmap.yaml:34
- This change adds only 'EnableStateMigration', while other dual-stack overlays include additional configuration keys. Consider adding the missing fields (e.g., "MetricsBindAddress" and possibly "EnableSubnetScarcity") for consistency.
"EnableStateMigration": false,
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rbtr
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Adding in fields that have 0 impact to current E2E as they default to false or are not used.
Issue Fixed:
Requirements:
Notes:
Will sort and organize bottom block to match default managed aks offering after #3502 has merged.