Scripts: Adds Stream APIs for CRUD Operations #4978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NaluTripician
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
FabianMeiswinkel,
kirillg and
Pilchie
as code owners
| /// <param name="cancellationToken"></param> | ||
| /// <returns>A <see cref="Task"/> containing a <see cref="ResponseMessage"/> containing the created stored procedure</returns> | ||
| public abstract Task<ResponseMessage> CreateStoredProcedureStreamAsync( | ||
| Stream streamPayload, |
There was a problem hiding this comment.
Metadata stream API's take the types themselves, as service don't accept any arbitrary payloads. please update all API's
| /// <returns>A <see cref="Task"/> containing a <see cref="ResponseMessage"/> containing the created stored procedure</returns> | ||
| public abstract Task<ResponseMessage> CreateStoredProcedureStreamAsync( | ||
| Stream streamPayload, | ||
| string id, |
| /// <summary> | ||
| /// Creates a stored procedure as an asynchronous operation in the Azure Cosmos DB service. | ||
| /// </summary> | ||
| /// <param name="streamPayload"></param> |
There was a problem hiding this comment.
Please expand with documentation and also a code usage sample.
| /// <returns>A <see cref="Task"/> containing a <see cref="ResponseMessage"/>.</returns> | ||
| public abstract Task<ResponseMessage> ReplaceStoredProcedureStreamAsync( | ||
| Stream streamPayload, | ||
| string id, |
| uriPathSegment: Paths.StoredProceduresPathSegment, | ||
| id: id); | ||
|
|
||
| return await this.ProcessStreamOperationAsync( |
There was a problem hiding this comment.
General pattern is Typed API's are layered over stream API.
And typed API wil do the extra ResponseFactory.CreateResponse part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Adds new Stream APIs for CRUD operations on stored procedures, triggers, and user defined functions in the
Scriptsnamespace.Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #4951