Fixing --enableAuth param when tested locally
#4211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liliankasem
previously approved these changes
Dec 11, 2024
fabiocav
reviewed
Dec 11, 2024
fabiocav
previously approved these changes
Dec 11, 2024
aishwaryabh
dismissed stale reviews from fabiocav and liliankasem
via
b3bc8a1
jviau
previously approved these changes
Dec 17, 2024
liliankasem
previously approved these changes
Dec 17, 2024
liliankasem
approved these changes
Jan 6, 2025
…tools into aibhandari/fix-enable-auth-param
fabiocav
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
When testing core tools locally, the
--enableAuthparam allows users to enable authorization. There was a bug introduced in this authorization handlerwhere the auth will always be bypassed regardless of the parameter. This PR fixes the issue by only setting up the authorization handler if the
--enableAuthparam is not set. I've also added test coverage for the--enableAuthparameter.Pull request checklist