Include Exception Properties at FailureDetails via Custom Provider #3215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andystaples
reviewed
Oct 8, 2025
| return false; | ||
| } | ||
|
|
||
| public static IDictionary<string, object?> TryExtractPropertiesFromExceptionJson(string json) |
There was a problem hiding this comment.
Generally methods beginning with "Try" should return a bool representing if the operation was successful, and the parsed result as an "out" parameter.
I'm also a bit concerned about exception handling here - if "json" is not a valid json string, JsonNode.Parse() will throw. Can we add try/catch around the contents of this method and just return false if an exception is thrown?
andystaples
reviewed
Oct 14, 2025
| // Call the activity that will throw an exception | ||
| try | ||
| { | ||
| await context.CallActivityAsync(nameof(BusinessActivity)); |
There was a problem hiding this comment.
Can we correct the warning here? Should just need to pass an input or change the return type of BuisnessActivity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
Add support for including exception properties at TaskFailureDetails via custom provider
Note: This PR won't work unless microsoft/durabletask-dotnet#474 is merged.
Pull request checklist
pending_docs.mdrelease_notes.md/src/Worker.Extensions.DurableTask/AssemblyInfo.csdevandmainbranches and will not be merged into thev2.xbranch.