-
Notifications
You must be signed in to change notification settings - Fork 461
add warning log for end of support extension bundles versions #11075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyju
reviewed
Jun 4, 2025
jviau
reviewed
Jun 19, 2025
kshyju
reviewed
Jun 26, 2025
kshyju
approved these changes
Jul 1, 2025
test/WebJobs.Script.Tests/Description/FunctionAppValidationServiceTests.cs
Show resolved
Hide resolved
test/WebJobs.Script.Tests/Description/FunctionAppValidationServiceTests.cs
Show resolved
Hide resolved
manvkaur
commented
Jul 2, 2025
RohitRanjanMS
approved these changes
Jul 2, 2025
This is nice when is it (roughly) expected to be deployed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #https://github.com/Azure/azure-functions-pyfx-planning/issues/713

screenshot of working log in app insights -
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-proc
branch to be included in Core Tools and non-Flex deployments.in-proc
branch is not requiredrelease_notes.md
Additional information
This pull request introduces changes to enhance validation mechanisms for function apps, improve logging for outdated extension bundles.
Validation Enhancements:
IFunctionAppValidator
interface to support modular validation logic for function apps. (src/WebJobs.Script/Host/IFunctionAppValidator.cs
)ExtensionBundleManagerValidator
andMissingAzureFunctionsFolderValidator
classes to validate outdated extension bundles and improper folder structures, respectively. (src/WebJobs.Script/Host/ExtensionBundleManagerValidator.cs
,src/WebJobs.Script/Host/MissingAzureFunctionsFolderValidator.cs
) [1] [2]FunctionAppValidationService
to use a collection of validators for streamlined validation and improved error handling. (src/WebJobs.Script/Host/FunctionAppValidationService.cs
) [1] [2]Logging Improvements:
src/WebJobs.Script/Diagnostics/Extensions/LoggerExtension.cs
,src/WebJobs.Script/Properties/Resources.Designer.cs
,src/WebJobs.Script/Properties/Resources.resx
) [1] [2] [3]ExtensionBundleManager
class to generate warnings based on bundle version and deprecation timelines. (src/WebJobs.Script/ExtensionBundle/ExtensionBundleManager.cs
)Platform Configuration Updates:
x86
bitness mapping inNew-PrivateSiteExtension.ps1
to reflect "32bit" instead of "64bit." (src/WebJobs.Script.SiteExtension/New-PrivateSiteExtension.ps1
)Test Suite Updates:
FunctionAppValidationService
. (test/WebJobs.Script.Tests.Integration/TestFunctionHost.cs
,test/WebJobs.Script.Tests/Description/FunctionAppValidationServiceTests.cs
) [1] [2]Miscellaneous:
release_notes.md
)