Skip to content

[in-proc] Backport log level changes and failure handling from #11100 #11156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 1, 2025

Conversation

cjaliaga
Copy link
Member

This PR backports the changes from #11100 that are relevant to in-proc:

  • Changed logging levels from Error to Warning to better reflect the severity of the issues.
  • Disabled the service when there's any failure (even if transient) as part of flushing logs, purging events, or executing a batch.

The rest of the changes in #11100 only apply to the OOP host and are not needed for in-proc.

resolves #11097

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@cjaliaga cjaliaga merged commit 032551f into in-proc Jul 1, 2025
9 checks passed
@cjaliaga cjaliaga deleted the cjaliaga/in-proc-11097 branch July 1, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Error occurred when attempting to purge previous diagnostic event versions" on v4.839.500, v4.639.500 and v4.1039.500
3 participants