Conversation
src/WebJobs.Script.Grpc/azure-functions-language-worker-protobuf/src/proto/FunctionRpc.proto
Outdated
Show resolved
Hide resolved
src/WebJobs.Script.WebHost/Security/Authorization/Policies/AuthorizationOptionsExtensions.cs
Outdated
Show resolved
Hide resolved
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\WebJobs.Script.Abstractions\WebJobs.Script.Abstractions.csproj" /> |
There was a problem hiding this comment.
TODO: remove testing change --> need to release abstractions project and reference released package in this PR before merging.
src/WebJobs.Script.Abstractions/AppCapabilities/AppCapabilitiesOptions.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script.Abstractions/AppCapabilities/AppCapabilitiesOptions.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script/AppCapabilities/AppCapabilitiesOptionsSetup.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script.WebHost/Controllers/AppCapabilitiesController.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script/AppCapabilities/AppCapabilitiesOptionsSetup.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script.WebHost/Controllers/AppCapabilitiesController.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script/AppCapabilities/DefaultAppCapabilitiesProvider.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script/AppCapabilities/DefaultAppCapabilitiesProvider.cs
Outdated
Show resolved
Hide resolved
…tration from webjobs extension
5871c63 to
2e2de7c
Compare
src/WebJobs.Script/AppCapabilities/AppCapabilitiesChangeTokenSource.cs
Outdated
Show resolved
Hide resolved
liliankasem
left a comment
There was a problem hiding this comment.
Approach taken looks good to me, just missing tests
jviau
left a comment
There was a problem hiding this comment.
I think there are still lifetime/access/resolution issues between script host and web host copies of AppCapabilitiesOptions. See my comment in the review discussing it.
src/WebJobs.Script.Abstractions/AppCapabilities/AppCapabilitiesOptions.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script.WebHost/AppCapabilities/AppCapabilitiesController.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script.WebHost/AppCapabilities/AppCapabilitiesController.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script.WebHost/AppCapabilities/AppCapabilitiesController.cs
Outdated
Show resolved
Hide resolved
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\WebJobs.Script.Abstractions\WebJobs.Script.Abstractions.csproj" /> |
There was a problem hiding this comment.
We will need to review that our CI is producing and publishing new abstractions packages. If it isn't, core tools will fail restore.
src/WebJobs.Script.WebHost/AppCapabilities/AppCapabilitiesController.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script.Abstractions/AppCapabilities/AppCapabilitiesOptions.cs
Outdated
Show resolved
Hide resolved
| var capabilitiesSection = _configuration.GetSection(ConfigurationSectionNames.AppCapabilities); | ||
| if (capabilitiesSection.Exists()) | ||
| { | ||
| AddCapabilitiesFromSection(optionsDict, capabilitiesSection); |
There was a problem hiding this comment.
What's the scenario for this? Do we expect someone to add this as an app setting to express some capabilities?
There was a problem hiding this comment.
This is for setting capabilities in host.json (customer provided values, their own customer scenarios).
src/WebJobs.Script/AppCapabilities/DefaultAppCapabilitiesStore.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script/AppCapabilities/DefaultAppCapabilitiesStore.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 30 out of 30 changed files in this pull request and generated 7 comments.
You can also share your feedback on Copilot code review. Take the survey.
test/WebJobs.Script.Tests/Workers/Rpc/GrpcWorkerChannelTests.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script.Abstractions/AppCapabilities/AppCapabilitiesOptions.cs
Show resolved
Hide resolved
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
…/Azure/azure-functions-host into satvu/app-capabilities-prototype
Issue describing the changes in this PR
resolves #11574
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-procbranch to be included in Core Tools and non-Flex deployments.in-procbranch is not requiredrelease_notes.mdAdditional Comments
The two new endpoints added (
admin/capabilitiesandadmin/capabilities/{name}) can be used by partners or customers to quickly query for an app's capabilities/features and related values (endpoints, names, etc.). Capabilities include values that can be set by extensions, language workers, customers, and the host.One example: At the ARM level, the
admin/capabilitiesendpoint can be called and the values can be stored in ARG for later purposes (such as querying/filtering apps for a dashboard).Related PRs: