Dont use timer if closed #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
============================================
- Coverage 56.50% 56.48% -0.03%
Complexity 731 731
============================================
Files 106 106
Lines 3837 3842 +5
Branches 393 395 +2
============================================
+ Hits 2168 2170 +2
- Misses 1488 1489 +1
- Partials 181 183 +2
|
|
Can you please add a description? |
yogilad
approved these changes
Jul 23, 2023
AsafMah
approved these changes
Jul 24, 2023
AsafMah
reviewed
Jul 25, 2023
| @@ -28,6 +28,11 @@ public abstract class PublicAppTokenProviderBase extends MsalTokenProviderBase { | |||
| super(clusterUrl, authorityId, httpClient); | |||
| } | |||
|
|
|||
| @Override | |||
| protected synchronized String acquireAccessTokenImpl() throws DataServiceException, DataClientException { | |||
There was a problem hiding this comment.
Add a comment explaining this.
AsafMah
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.