-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telemetry Documentation #318
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #318 +/- ##
=========================================
Coverage 56.48% 56.48%
Complexity 731 731
=========================================
Files 106 106
Lines 3842 3842
Branches 395 395
=========================================
Hits 2170 2170
Misses 1489 1489
Partials 183 183 |
@@ -0,0 +1,40 @@ | |||
# Enabling Telemetry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intended for SDK maintainers or SDK users?
I'm getting mixed signals.
|
||
## 1. Configuration | ||
|
||
Before using monitored activity functionality throughout the project, you'll need to configure an instance of the Azure Core Tracer interface and initialize a Kusto SDK Tracer with it. The Azure Core Tracer interface is part of the Azure Core Tracing library, which is a dependency of the Kusto SDK. The Kusto SDK Tracer is part of the Kusto SDK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SDK Users need code samples and clear instructions.
|
||
The monitored activity package provides an invoker to help you track user activity: | ||
|
||
- `MonitoredActivity.invoke`: Invokes the main logic of the application while enabling monitored activity telemetry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems relevant for maintainers (or I'm missing something)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should add some examples of insights one can get after configuration completed
|
||
## 2. Usage Example | ||
|
||
The SampleApp project demonstrates how to use monitored activity telemetry along with the provided SDK functions. The main entry point of the application is the `SampleApp.main` method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add link to the sample app
|
||
Refer to the SDK documentation for more details on each function and their parameters. | ||
|
||
## 4. Enabling Tracing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sample app open telemtry config is for Kusto extension of OpenTelemtry?
@enmoed please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #318 +/- ##
=========================================
Coverage 58.72% 58.72%
Complexity 838 838
=========================================
Files 111 111
Lines 4068 4068
Branches 428 428
=========================================
Hits 2389 2389
Misses 1484 1484
Partials 195 195 ☔ View full report in Codecov by Sentry. |
Added
Documentation covering the configuration and usage of tracers in the instrumentation package.
Changed
Fixed