Adding new cmdlet to retrieve NVA boot diagnostics #27060

nanditaashok-ms · 2025-01-29T21:53:04Z

Description

https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1476

Mandatory Checklist

Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
- General release
- Public preview
- Private preview
- Engineering build
- No need for a release
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- For autorest-based development mode, include the changelog in the PR description.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2025-01-29T21:53:08Z

⚠️Az.Accounts

️✔️Az.Aks

️✔️Az.ApplicationInsights

️✔️Az.Batch

️✔️Az.CognitiveServices

️✔️Az.Compute

️✔️Az.ContainerRegistry

️✔️Az.CosmosDB

️✔️Az.DataLakeStore

️✔️Az.Dns

️✔️Az.EventHub

️✔️Az.Functions

⚠️Az.KeyVault

️✔️Az.KubernetesConfiguration

️✔️Az.Maintenance

️✔️Az.ManagedServiceIdentity

⚠️Az.Monitor

⚠️Az.NetAppFiles

️✔️Az.Network

️✔️Az.OperationalInsights

️✔️Az.PostgreSql

️✔️Az.PrivateDns

⚠️Az.Purview

️✔️Az.RecoveryServices

⚠️Az.Resources

️✔️Az.Security

️✔️Az.ServiceBus

️✔️Az.SignalR

⚠️Az.Sql

⚠️Az.Storage

️✔️Az.Websites

YanaXu · 2025-02-05T02:29:26Z

/azp run

azure-pipelines · 2025-02-05T02:29:41Z

Azure Pipelines successfully started running 3 pipeline(s).

NoriZC · 2025-02-06T08:00:05Z

Hi @nanditaashok-ms, our CI reflects that files under src/Network/Network.Management.Sdk/Generated might be manually updated, which is unexpected. You may need to rebase on the latest main, regenerate code accroding to README.md file under src/Network/Network.Management.Sdk, and make sure no more updates based on generated files.

github-actions · 2025-02-06T08:00:44Z

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

nanditaashok-ms · 2025-02-06T20:04:05Z

@NoriZC the generated files weren't modified manually. They were generated based on the latest commit at the time in the upcoming swagger release branch: - Azure/azure-rest-api-specs@main...kamboj-prjwl/release-network-Microsoft.Network-2024-07-01
Until this swagger release branch is merged into main swagger branch, I'm not sure if the corresponding powershell release branch that I'm trying to merge to will automatically pick up the latest commits from the swagger release branch and generate the sdk accordingly.

NoriZC · 2025-02-07T05:40:01Z

/azp run

azure-pipelines · 2025-02-07T05:40:16Z

Azure Pipelines successfully started running 3 pipeline(s).

NoriZC · 2025-02-07T06:37:59Z

/azp run

azure-pipelines · 2025-02-07T06:38:14Z

Azure Pipelines successfully started running 3 pipeline(s).

nanditaashok-ms · 2025-02-10T21:31:26Z

@NoriZC could you please let me know what is pending to get this PR merged. I had responded to your comment on the generated files. Is there anything else that is blocking the merge of this PR?

NoriZC · 2025-02-11T03:05:47Z

The Resources issue is resolved in main branch yesterday, so the first thing to do is to merge the latest main branch.
The Generated sdk seems to be not fitting what it should be. Could you run autorest to generate a new version and compare with current branch using git status to confirm that no manual updates is made occasionally? (I have run with the latest autroest, and while running git diff there are lots of records there. Please double check and fix it.)
There is a test issue as well, please help check it:
Commands.Network.Test.ScenarioTests.NetworkVirtualApplianceBootDiagnosticsTest.TestNetworkVirtualApplianceBootDiagnostics [FAIL]

NoriZC · 2025-02-11T08:39:24Z

/azp run

azure-pipelines · 2025-02-11T08:39:38Z

Azure Pipelines successfully started running 3 pipeline(s).

NoriZC · 2025-02-12T06:08:12Z

/azp run

azure-pipelines · 2025-02-12T06:08:27Z

Azure Pipelines successfully started running 3 pipeline(s).

NoriZC · 2025-02-12T15:34:54Z

/azp run

azure-pipelines · 2025-02-12T15:35:10Z

Azure Pipelines successfully started running 3 pipeline(s).

Adding new cmdlet to retrieve NVA boot diagnostics

ebec911

nanditaashok-ms added 3 commits February 5, 2025 14:29

fix typo and add test recording

cd43a87

add help files

b955463

update test

2f2f4b0

NoriZC self-assigned this Feb 6, 2025

NoriZC added the needs-revision label Feb 6, 2025

Add online version link to documentation

c6d767c

NoriZC and others added 2 commits February 11, 2025 15:54

resolve generated sdk issue

e8c09e1

Fix bicep template issue due to bicep version upgrade (Azure#27096)

0120564

nanditaashok-ms requested review from isra-fel, bilaakpan-ms, Sandido, haagha and grizzlytheodore as code owners February 12, 2025 05:14

NoriZC force-pushed the nvabootdiag-pscmd branch from 8fd6d8a to 0120564 Compare February 12, 2025 06:04

update test case

98b758f

Azure deleted a comment from azure-pipelines bot Feb 12, 2025

remove secrets

49f47d5

NoriZC approved these changes Feb 13, 2025

View reviewed changes

NoriZC merged commit 011e912 into Azure:release-network-2024-07-01 Feb 13, 2025
12 checks passed

Adding new cmdlet to retrieve NVA boot diagnostics #27060

Adding new cmdlet to retrieve NVA boot diagnostics #27060

Uh oh!

Conversation

nanditaashok-ms commented Jan 29, 2025

Description

Mandatory Checklist

Uh oh!

azure-client-tools-bot-prd bot commented Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

YanaXu commented Feb 5, 2025

Uh oh!

azure-pipelines bot commented Feb 5, 2025

Uh oh!

NoriZC commented Feb 6, 2025

Uh oh!

github-actions bot commented Feb 6, 2025

Uh oh!

nanditaashok-ms commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NoriZC commented Feb 7, 2025

Uh oh!

azure-pipelines bot commented Feb 7, 2025

Uh oh!

NoriZC commented Feb 7, 2025

Uh oh!

azure-pipelines bot commented Feb 7, 2025

Uh oh!

nanditaashok-ms commented Feb 10, 2025

Uh oh!

NoriZC commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NoriZC commented Feb 11, 2025

Uh oh!

azure-pipelines bot commented Feb 11, 2025

Uh oh!

NoriZC commented Feb 12, 2025

Uh oh!

azure-pipelines bot commented Feb 12, 2025

Uh oh!

NoriZC commented Feb 12, 2025

Uh oh!

azure-pipelines bot commented Feb 12, 2025

Uh oh!

Uh oh!

Uh oh!

azure-client-tools-bot-prd bot commented Jan 29, 2025 •

edited

Loading

nanditaashok-ms commented Feb 6, 2025 •

edited

Loading

NoriZC commented Feb 11, 2025 •

edited

Loading