Oracle DB@Azure-2023-09-01-preview version #28090

acaicici · 2024-03-05T22:28:53Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Click here to see the details of Step 1

Breaking changes review (Diagram Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
You believe there is no need for you to request breaking change approval, for any reason.
Such claims must be reviewed, and the process is the same.

Click here to see the details of Step 2

ARM API changes review (Diagram Step 2)

For help with Step 2 / "ARM review", see https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2024-03-05T22:28:56Z

Next Steps to Merge

Next steps that must be taken to merge this PR:

❌ This is the public specs repo main branch which is not intended for iterative development.
You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
If this is what you intend, add PublishToCustomers label to your PR.
Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).

openapi-pipeline-app · 2024-03-05T22:28:57Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️❌CredScan: 0 Errors, 0 Warnings failed [Detail]

️❌LintDiff: 2 Errors, 33 Warnings failed [Detail]

Compared specs (v2.2.0)	new version	base version
package-2023-09-01-preview	package-2023-09-01-preview(61d48b9)	default(main)

[must fix]The following errors/warnings are introduced by current PR:

Only 30 items are listed, please refer to log for more details.

Rule	Message	Related RPC [For API reviewers]
`❌` EvenSegmentedPathForPutOperation	API path with PUT operation defined MUST have even number of segments (i.e. end in {resourceType}/{resourceName} segments). Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L896	RPC-Put-V1-02
`❌` XmsPageableForListCalls	`x-ms-pageable` extension must be specified for LIST APIs. Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L897	RPC-Get-V1-13
⚠️ PageableOperation	Based on the response model schema, operation 'CloudExadataInfrastructures_Get' might be pageable. Consider adding the x-ms-pageable extension. Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L2146
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L3671
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L3676
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L3914
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L3923
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L3949
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L3958
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L3979
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L3988
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L4156
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L4413
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L4418
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L4834
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L4843
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L4861
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L4870
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L5036
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L5041
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L5046
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L5051
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L5849
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L5866
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L6367
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L6372
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L6377
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L7419
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L7547
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Oracle.Database/preview/2023-09-01-preview/openapi.json#L7719

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-03-05T22:28:57Z

Swagger Generation Artifacts

️❌ApiDocPreview: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` RestBuild error	"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=426343&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 "

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed in generating from c07b44ffb2b6fcc7e183369eed1f21543c1e527b. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to build sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to packe sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  807 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk artifact

❌Azure.ResourceManager.Oracle [Preview SDK Changes]
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning in generating from c07b44ffb2b6fcc7e183369eed1f21543c1e527b. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 10.5.0 -> 10.6.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.6.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️azure-mgmt-oracledatabase [Preview SDK Changes]
- azure-mgmt-oracledatabase-1.0.0b1.zip
- azure_mgmt_oracledatabase-1.0.0b1-py3-none-any.whl
```
info	[Changelog]   - Initial Release
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning in generating from c07b44ffb2b6fcc7e183369eed1f21543c1e527b. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh]
cmderr	[init.sh] npm notice New minor version of npm available! 10.5.0 -> 10.6.0
cmderr	[init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.6.0>
cmderr	[init.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[init.sh] npm notice
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-oracle [Preview SDK Changes]
- pom.xml
- azure-resourcemanager-oracle-1.0.0-beta.1.jar
- azure-resourcemanager-oracle-1.0.0-beta.1-sources.jar

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded in generating from c07b44ffb2b6fcc7e183369eed1f21543c1e527b. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-Oracle.Database [Preview SDK Changes]
- azure-arm-Oracle.Database-1.0.0-beta.1.tgz

️❌ azure-resource-manager-schemas failed [Detail]

❌Failed in generating from c07b44ffb2b6fcc7e183369eed1f21543c1e527b. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  notice
cmderr	[initScript.sh] npm notice New minor version of npm available! 10.5.0 -> 10.6.0
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.6.0>
cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

❌oracle/resource-manager

️⚠️ azure-powershell warning [Detail]

⚠️Warning in generating from c07b44ffb2b6fcc7e183369eed1f21543c1e527b. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

⚠️Az.oracle.DefaultTag [Preview SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-03-05T22:28:58Z

Generated ApiView

Language	Package Name	ApiView Link
Java	azure-resourcemanager-oracle	https://apiview.dev/Assemblies/Review/aacb5928170244f28489af4b3929121f?revisionId=ba26755ff5df4b68bf844a2c3b0d8901
JavaScript	@azure/arm-Oracle.Database	https://apiview.dev/Assemblies/Review/943ccdca57584198ab5b68673e5c7003?revisionId=f32893427c1c488d896bc640591c3e7e
Swagger	Oracle.Database	https://apiview.dev/Assemblies/Review/7925a5eb76cc40d796205a42634f733a?revisionId=c612366c9f47466c8d42b516c45b6e2a

openapi-workflow-bot · 2024-03-05T22:38:10Z

Hi, @acaicici, our workflow has detected that there is no management SDK ever released for your RP, to further process SDK onboard for your RP, you should have the SDK client library name of your RP reviewed and approved.
Action Required:

Follow this guidance Naming for new initial management or client libraries (new SDKs) - Overview (azure.com) to create an issue for management client library name arch board review.

Paste the issue link that you created in step 1 in this PR

Impact: SDK release owner will take the approved management client library name to release SDK. No client library name approval will leads to SDK release delayed.

korser1 · 2024-03-07T01:13:09Z

you need to fix spell check errors
use custom-words.txt , not cspell.json

This reverts commit 93840b5.

tjprescott · 2024-03-08T20:55:19Z

/azp run Swagger LintDiff

v-mmu · 2024-04-24T21:41:08Z

I see lots of lintdiff warnings about booleans. Please reconsider whether you want to really want to use each boolean property as boolean. Just as a default guidance, Booleans are not something we recommend in Azure APIs unless there's obviously no sensible alternative - because they are less future proof hard to extend in the future

Those are booleans and we don't anticipate any extension.

openapi-pipeline-app · 2024-04-25T18:11:34Z

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

openapi-pipeline-app · 2024-04-25T19:04:54Z

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

# Conflicts: # custom-words.txt

v-mmu · 2024-04-25T22:28:04Z

Context :
Roopesh Manda ( @rkmanda ) and Sergey @korser1 were previously involved and aggreged the failing LintDiff Errors can be overridden. The API is currently in production and customers are using it. Fixing the LintDiff errors are breaking change.

Ask to @TimLovellSmith :
Can you please provide an override for LintDiff failure checks?. If you can’t provide an override, Can you point us to someone who can?.

API Details:
URL : /subscriptions/{subscriptionId}/providers/Oracle.Database/oracleSubscriptions/default
HTTP method affected : PUT, GET(list), and Patch.

mikeharder · 2024-04-25T22:30:04Z

LintDiff failures are due to this tool bug:

Azure/azure-openapi-validator#646

mikeharder · 2024-04-25T22:33:02Z

@v-mmu: Is your swagger hand-written or generated from TypeSpec? It doesn't contain x-typespec-generated, but I've only seen failures caused by Azure/azure-openapi-validator#646 in TypeSpec-generated swagger.

v-mmu · 2024-04-25T22:46:05Z

@v-mmu: Is your swagger hand-written or generated from TypeSpec? It doesn't contain x-typespec-generated, but I've only seen failures caused by Azure/azure-openapi-validator#646 in TypeSpec-generated swagger.

This is generated from the TypeSpec. But - We are told to suppress it for this release.

v-mmu · 2024-04-25T22:48:29Z

@v-mmu: Is your swagger hand-written or generated from TypeSpec? It doesn't contain x-typespec-generated, but I've only seen failures caused by Azure/azure-openapi-validator#646 in TypeSpec-generated swagger.

Does that mean Lint Check failures can be ignored and ready for merge?.

v-mmu · 2024-04-25T22:54:07Z

/pr RequestMerge

mikeharder · 2024-04-25T23:01:18Z

@v-mmu: Is your swagger hand-written or generated from TypeSpec? It doesn't contain x-typespec-generated, but I've only seen failures caused by Azure/azure-openapi-validator#646 in TypeSpec-generated swagger.

This is generated from the TypeSpec. But - We are told to suppress it for this release.

I think it would be easier to just add your TypeSpec sources to this PR, but if you have been granted an exception, OK.

v-mmu · 2024-04-26T13:50:30Z

@TimLovellSmith @ramoka178 - The next step is add "ARMSignedOff" from you/reviewers.

Please let me know if there is anything else I should do - I requested for a merge.

ramoka178

Approving to merge

v-mmu · 2024-04-26T18:28:05Z

Thanks @ramoka178 @TimLovellSmith for the help.

inital release of 2023-09-01-preview version

454a67d

acaicici requested review from msyyc, tadelesh, jsntcy and qiaozha as code owners March 5, 2024 22:28

azure-sdk mentioned this pull request Mar 5, 2024

[AutoPR oracle] Oracle DB@Azure-2023-09-01-preview version azure-sdk/azure-resource-manager-schemas#4323

Draft

AzureRestAPISpecReview added ARMReview new-api-version new-rp-namespace resource-manager RPaaS TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 5, 2024

acaicici force-pushed the oracle.database/2023-09-01-preview branch from b2ba9cf to 270dcb5 Compare March 6, 2024 18:47

fix spellcheck errors

93840b5

acaicici force-pushed the oracle.database/2023-09-01-preview branch from 7aa63ff to 93840b5 Compare March 6, 2024 19:06

vboxuser added 2 commits March 7, 2024 11:19

Revert "fix spellcheck errors"

6a8aad6

This reverts commit 93840b5.

update custom-words.txt to fix spellchecks errors

ee599ee

Updated latest changes.

691c0d4

Resolve conflicts

e84c423

Merge branch 'refs/heads/main' into oracle.database/2023-09-01-preview

90195ca

# Conflicts: # custom-words.txt

azure-sdk mentioned this pull request Apr 25, 2024

[AutoPR azure-mgmt-oracledatabase] Oracle DB@Azure-2023-09-01-preview version azure-sdk/azure-sdk-for-python#7003

Closed

v-mmu added 2 commits April 25, 2024 13:48

Added adbbackupid.

92783de

Added TypeSpec exclusion.

3a16f98

Merge branch 'main' into oracle.database/2023-09-01-preview

4c30903

microsoft-github-policy-service bot added the MergeRequested label Apr 25, 2024

ramoka178 added the Approved-LintDiff label Apr 25, 2024

Merge branch 'main' into oracle.database/2023-09-01-preview

1c88898

AzureRestAPISpecReview removed the TypeSpec Authored with TypeSpec label Apr 26, 2024

Merge branch 'main' into oracle.database/2023-09-01-preview

61d48b9

ramoka178 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Apr 26, 2024

openapi-workflow-bot bot removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Apr 26, 2024

ramoka178 approved these changes Apr 26, 2024

View reviewed changes

ramoka178 merged commit 23a5e38 into Azure:main Apr 26, 2024
28 of 32 checks passed

v-jamcheung mentioned this pull request May 22, 2024

.NET SDK for Oracle.Database Azure/azure-sdk-for-net#44106

Closed

mikekistler added the Oracle label Sep 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Oracle DB@Azure-2023-09-01-preview version #28090

Oracle DB@Azure-2023-09-01-preview version #28090

acaicici commented Mar 5, 2024

openapi-pipeline-app bot commented Mar 5, 2024 •

edited

Loading

openapi-pipeline-app bot commented Mar 5, 2024 •

edited

Loading

openapi-pipeline-app bot commented Mar 5, 2024 •

edited

Loading

openapi-pipeline-app bot commented Mar 5, 2024 •

edited

Loading

openapi-workflow-bot bot commented Mar 5, 2024

korser1 commented Mar 7, 2024

tjprescott commented Mar 8, 2024

v-mmu commented Apr 24, 2024

openapi-pipeline-app bot commented Apr 25, 2024

openapi-pipeline-app bot commented Apr 25, 2024

v-mmu commented Apr 25, 2024

mikeharder commented Apr 25, 2024

mikeharder commented Apr 25, 2024

v-mmu commented Apr 25, 2024

v-mmu commented Apr 25, 2024

v-mmu commented Apr 25, 2024

mikeharder commented Apr 25, 2024

v-mmu commented Apr 26, 2024

ramoka178 left a comment

v-mmu commented Apr 26, 2024

Oracle DB@Azure-2023-09-01-preview version #28090

Oracle DB@Azure-2023-09-01-preview version #28090

Conversation

acaicici commented Mar 5, 2024

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Breaking changes review (Diagram Step 1)

ARM API changes review (Diagram Step 2)

Diagram footnotes

Purpose of this PR

Due diligence checklist

Additional information

Getting help

openapi-pipeline-app bot commented Mar 5, 2024 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Mar 5, 2024 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Mar 5, 2024 • edited Loading

Swagger Generation Artifacts

openapi-pipeline-app bot commented Mar 5, 2024 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Mar 5, 2024

korser1 commented Mar 7, 2024

tjprescott commented Mar 8, 2024

v-mmu commented Apr 24, 2024

openapi-pipeline-app bot commented Apr 25, 2024

openapi-pipeline-app bot commented Apr 25, 2024

v-mmu commented Apr 25, 2024

mikeharder commented Apr 25, 2024

mikeharder commented Apr 25, 2024

v-mmu commented Apr 25, 2024

v-mmu commented Apr 25, 2024

v-mmu commented Apr 25, 2024

mikeharder commented Apr 25, 2024

v-mmu commented Apr 26, 2024

ramoka178 left a comment

Choose a reason for hiding this comment

v-mmu commented Apr 26, 2024

openapi-pipeline-app bot commented Mar 5, 2024 •

edited

Loading

openapi-pipeline-app bot commented Mar 5, 2024 •

edited

Loading

openapi-pipeline-app bot commented Mar 5, 2024 •

edited

Loading

openapi-pipeline-app bot commented Mar 5, 2024 •

edited

Loading