Integrate Armstrong Validation into the spec PR check. #28829
+218
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ms-zhenhua
requested review from
weshaggard,
mikeharder and
konrad-jamrozik
as code owners
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
Swagger Generation Artifacts
|
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
mikeharder
reviewed
Apr 25, 2024
mikeharder
reviewed
Apr 25, 2024
eng/scripts/Armstrong-Validation.ps1
Outdated
| function Validate-Terraform-Error($repoPath, $filePath) { | ||
| $fileDirectory = (Split-Path -Parent $filePath) | ||
|
|
||
| $outputDirectory = Join-Path -Path $fileDirectory -ChildPath "58d50903-36e9-4f57-a1e5-f246d7ecdec0" |
There was a problem hiding this comment.
You should create a unique temp directory using code like this:
Suggested change
| $outputDirectory = Join-Path -Path $fileDirectory -ChildPath "58d50903-36e9-4f57-a1e5-f246d7ecdec0" | |
| $outputDirectory= [System.IO.Path]::Combine([System.IO.Path]::GetTempPath(), [System.IO.Path]::GetRandomFileName()) | |
| try { | |
| New-Item -Path $outputDirectory -ItemType Directory |
There was a problem hiding this comment.
code updated. Thanks.
mikeharder
reviewed
Apr 25, 2024
mikeharder
reviewed
Apr 25, 2024
mikeharder
reviewed
Apr 26, 2024
mikeharder
reviewed
Apr 26, 2024
| vmImage: ubuntu-22.04 | ||
|
|
||
| # refer to https://github.com/MicrosoftDocs/pipelines-go/blob/main/azure-pipelines.yml | ||
| variables: |
There was a problem hiding this comment.
Could the pipeline work without setting these vars? Because these would also need to be different on Windows vs Linux.
ms-zhenhua
force-pushed
the
ms-zhenhua/armstrong-validation
branch
from
333fb0e
to
da9dda0
Compare
ms-zhenhua
force-pushed
the
ms-zhenhua/armstrong-validation
branch
from
eda376f
to
440c631
Compare
mikeharder
reviewed
May 1, 2024
Comment on lines
+117
to
+122
| $outputDirectory = [System.IO.Path]::Combine([System.IO.Path]::GetTempPath(), [System.IO.Path]::GetRandomFileName()) | ||
| $result = @() | ||
|
|
||
| try { | ||
| if (!(Test-Path -Path $outputDirectory)) { | ||
| New-Item -Path $outputDirectory -ItemType Directory *> $null |
There was a problem hiding this comment.
Suggested change
| $outputDirectory = [System.IO.Path]::Combine([System.IO.Path]::GetTempPath(), [System.IO.Path]::GetRandomFileName()) | |
| $result = @() | |
| try { | |
| if (!(Test-Path -Path $outputDirectory)) { | |
| New-Item -Path $outputDirectory -ItemType Directory *> $null | |
| $outputDirectory = [System.IO.Directory]::CreateTempSubdirectory() | |
| $result = @() | |
| try { |
.NET 7 added an easier way to do this.
mikeharder
requested changes
May 1, 2024
mikeharder
reviewed
May 7, 2024
|
|
||
| # -NoEnumerate to prevent single-element arrays from being collapsed to a single object | ||
| # -AsHashtable is closer to raw JSON than PSCustomObject | ||
| $suppressions = npx get-suppressions ArmstrongValidation $fileInSpecFolder | ConvertFrom-Json -NoEnumerate -AsHashtable |
There was a problem hiding this comment.
@ms-zhenhua: I updated your PR to use the new get-suppressions shared code added in #28927, #29001, and #29008.
You may also want to add parameter $CheckAllUnder to your script for easier testing, like this:
AzureRestAPISpecReview
removed
the
VersioningReviewRequired
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate from #28803