Skip to content

SecurityInsights Incidents - Add mergedIncidentUrl and mergedIncidentNumber + Remove CreateTeam#32303

Merged
coled-ms merged 2 commits intoAzure:dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2025-01-01-previewfrom
IdoMSFT:dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2025-01-01-preview
Jan 29, 2025
Merged

SecurityInsights Incidents - Add mergedIncidentUrl and mergedIncidentNumber + Remove CreateTeam#32303
coled-ms merged 2 commits intoAzure:dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2025-01-01-previewfrom
IdoMSFT:dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2025-01-01-preview

Conversation

@IdoMSFT
Copy link
Contributor

@IdoMSFT IdoMSFT commented Jan 23, 2025

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 23, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 23, 2025

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/securityinsights/armsecurityinsights There is no API change compared with the previous version
Java azure-resourcemanager-securityinsights https://apiview.dev/Assemblies/Review/94d98f0a635f4ee98bd2349d9b276a14?revisionId=c99d6f67ed4542218416dbb1e02f6106

@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Jan 23, 2025
@microsoft-github-policy-service
Copy link
Contributor

Thank you for your contribution IdoMSFT! We will review the pull request and get back to you soon.

@IdoMSFT IdoMSFT changed the title Add mergedIncidentUrl and mergedIncidentNumber to Incidents.json SecurityInsights Incidents - Add mergedIncidentUrl and mergedIncidentNumber + Remove CreateTeam Jan 28, 2025
@gary-x-li gary-x-li added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jan 29, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 29, 2025
@IdoMSFT
Copy link
Contributor Author

IdoMSFT commented Jan 29, 2025

@microsoft-github-policy-service agree company="Microsoft"

@coled-ms coled-ms merged commit 6bc96c4 into Azure:dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2025-01-01-preview Jan 29, 2025
18 of 20 checks passed
xuhumsft added a commit that referenced this pull request Jan 31, 2025
…review (#32347)

* Copy files from preview/2024-10-01-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2025-01-01-preview

Updated the API version from preview/2024-10-01-preview to preview/2025-01-01-preview.

* Added tag for 2025-01-01-preview in readme file

* fix typo introduced by the powershell script

* prettier fix

* Adding SecurityInsights AutomationRules changes for 2025-01-01-preview API version (#32117)

* Fix SecurityInsights SourceControls spec for all previous versions (#32193)

* make the change

* Fix field name for old versions

* Adding SecurityInsights SourceControls changes for 2025-01-01-preview API version (#32192)

* make the change

* fix examples

* SecurityInsights Incidents - Add mergedIncidentUrl and mergedIncidentNumber + Remove CreateTeam (#32303)

* Add mergedIncidentUrl and mergedIncidentNumber to Incidents.json

* Remove Incident CreateTeam action from SecurityInsights

---------

Co-authored-by: xuhumsft <[email protected]>
Co-authored-by: Ron Cooper <[email protected]>
Co-authored-by: Brandon Qiao (Microsoft) <[email protected]>
Co-authored-by: IdoMSFT <[email protected]>
markcowl pushed a commit to markcowl/azure-rest-api-specs that referenced this pull request Feb 6, 2025
…review (Azure#32347)

* Copy files from preview/2024-10-01-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2025-01-01-preview

Updated the API version from preview/2024-10-01-preview to preview/2025-01-01-preview.

* Added tag for 2025-01-01-preview in readme file

* fix typo introduced by the powershell script

* prettier fix

* Adding SecurityInsights AutomationRules changes for 2025-01-01-preview API version (Azure#32117)

* Fix SecurityInsights SourceControls spec for all previous versions (Azure#32193)

* make the change

* Fix field name for old versions

* Adding SecurityInsights SourceControls changes for 2025-01-01-preview API version (Azure#32192)

* make the change

* fix examples

* SecurityInsights Incidents - Add mergedIncidentUrl and mergedIncidentNumber + Remove CreateTeam (Azure#32303)

* Add mergedIncidentUrl and mergedIncidentNumber to Incidents.json

* Remove Incident CreateTeam action from SecurityInsights

---------

Co-authored-by: xuhumsft <[email protected]>
Co-authored-by: Ron Cooper <[email protected]>
Co-authored-by: Brandon Qiao (Microsoft) <[email protected]>
Co-authored-by: IdoMSFT <[email protected]>
pjpatel12 pushed a commit to pjpatel12/azure-rest-api-specs that referenced this pull request Apr 29, 2025
…review (Azure#32347)

* Copy files from preview/2024-10-01-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2025-01-01-preview

Updated the API version from preview/2024-10-01-preview to preview/2025-01-01-preview.

* Added tag for 2025-01-01-preview in readme file

* fix typo introduced by the powershell script

* prettier fix

* Adding SecurityInsights AutomationRules changes for 2025-01-01-preview API version (Azure#32117)

* Fix SecurityInsights SourceControls spec for all previous versions (Azure#32193)

* make the change

* Fix field name for old versions

* Adding SecurityInsights SourceControls changes for 2025-01-01-preview API version (Azure#32192)

* make the change

* fix examples

* SecurityInsights Incidents - Add mergedIncidentUrl and mergedIncidentNumber + Remove CreateTeam (Azure#32303)

* Add mergedIncidentUrl and mergedIncidentNumber to Incidents.json

* Remove Incident CreateTeam action from SecurityInsights

---------

Co-authored-by: xuhumsft <[email protected]>
Co-authored-by: Ron Cooper <[email protected]>
Co-authored-by: Brandon Qiao (Microsoft) <[email protected]>
Co-authored-by: IdoMSFT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review customer-reported Issues that are reported by GitHub users external to the Azure organization. resource-manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants