Skip to content

[Cognitive Services] 2025-12-01 Stable 1RP API#40645

Merged
fmabroukmsft merged 5 commits intomainfrom
fmabrouk/cogsvc-2025-12-01
Mar 13, 2026
Merged

[Cognitive Services] 2025-12-01 Stable 1RP API#40645
fmabroukmsft merged 5 commits intomainfrom
fmabrouk/cogsvc-2025-12-01

Conversation

@fmabroukmsft
Copy link
Member

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
  • A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
  • For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

@github-actions
Copy link

github-actions bot commented Feb 23, 2026

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added resource-manager TypeSpec Authored with TypeSpec labels Feb 23, 2026
@github-actions
Copy link

github-actions bot commented Feb 23, 2026

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec Microsoft.CognitiveServices
JavaScript @azure/arm-cognitiveservices
Python azure-mgmt-cognitiveservices

Base automatically changed from migration/cognitiveservices to main March 5, 2026 03:33
@fmabroukmsft fmabroukmsft force-pushed the fmabrouk/cogsvc-2025-12-01 branch from 53b6cb6 to 36edb00 Compare March 5, 2026 18:34
@github-actions github-actions bot added ARMReview new-api-version WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NotReadyForARMReview BreakingChange-Go-Sdk SuppressionReviewRequired and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required SuppressionReviewRequired BreakingChange-JavaScript-Sdk labels Mar 5, 2026
@fmabroukmsft fmabroukmsft force-pushed the fmabrouk/cogsvc-2025-12-01 branch 2 times, most recently from d074bc7 to 0101549 Compare March 6, 2026 03:05
@fmabroukmsft fmabroukmsft force-pushed the fmabrouk/cogsvc-2025-12-01 branch from 0101549 to 811eae7 Compare March 6, 2026 03:06
@MushMal MushMal added the BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. label Mar 6, 2026
@github-actions github-actions bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Mar 6, 2026
@github-actions github-actions bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 10, 2026
@fmabroukmsft
Copy link
Member Author

#suppress "@azure-tools/typespec-azure-core/documentation-required" "Free pricing tier"

for these just remove the suppression and keep the description

Refers to: specification/cognitiveservices/CognitiveServices.Management/models.tsp:18 in eb43a4d. [](commit_id = eb43a4d, deletion_comment = False)

Will add these as true descriptions instead of suppressions as the service side code is updated, however, that will take some time

@fmabroukmsft fmabroukmsft added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested labels Mar 11, 2026
@github-actions github-actions bot added BreakingChange-Go-Sdk and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required BreakingChange-JavaScript-Sdk BreakingChange-Go-Sdk BreakingChange-Python-Sdk labels Mar 11, 2026
@fmabroukmsft fmabroukmsft force-pushed the fmabrouk/cogsvc-2025-12-01 branch from 019c9d6 to 21a71f5 Compare March 11, 2026 17:57
@fmabroukmsft fmabroukmsft force-pushed the fmabrouk/cogsvc-2025-12-01 branch from 069fd54 to 5925a07 Compare March 11, 2026 19:19
@fmabroukmsft fmabroukmsft added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested labels Mar 11, 2026
@fmabroukmsft fmabroukmsft force-pushed the fmabrouk/cogsvc-2025-12-01 branch from 7037735 to 49df057 Compare March 12, 2026 07:59
@razvanbadea-msft razvanbadea-msft added Approved-Suppression ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Mar 12, 2026
@github-actions github-actions bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 12, 2026
@fmabroukmsft fmabroukmsft added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Mar 13, 2026
@fmabroukmsft fmabroukmsft merged commit 3a8de15 into main Mar 13, 2026
93 of 95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-Suppression ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. BreakingChange-Go-Sdk BreakingChange-Go-Sdk-Approved BreakingChange-JavaScript-Sdk BreakingChange-JavaScript-Sdk-Approved BreakingChange-Python-Sdk BreakingChange-Python-Sdk-Approved BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required Cognitive Services new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager SuppressionReviewRequired TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants