Skip to content

Add support for building with ICU 75.1 or later #6486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antkmsft merged 2 commits into from
Apr 2, 2025
Merged

Add support for building with ICU 75.1 or later #6486

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0226ec
Add support for building with ICU 75.1 or later
kou Mar 27, 2025
8436d11
Update CHANGELOG
kou Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sdk/storage/azure-storage-common/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@

### Other Changes

- Added support for ICU 75.1 or later.

## 12.10.0 (2025-03-11)

### Features Added
Expand Down
4 changes: 4 additions & 0 deletions sdk/storage/azure-storage-common/src/xml_wrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@
#endif
#include <webservices.h>
#else
// libxml2 uses ICU. ICU 75.1 or later requires C++17 but we use
// C++14. It causes an error. We can disable ICU C++ API to avoid it
// because we don't need ICU C++ API.
#define U_SHOW_CPLUSPLUS_API 0
#include <libxml/xmlreader.h>
#include <libxml/xmlwriter.h>
#endif
Expand Down
2 changes: 2 additions & 0 deletions sdk/tables/azure-data-tables/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@

### Other Changes

- Added support for ICU 75.1 or later.

## 1.0.0-beta.6 (2025-01-22)

### Breaking Changes
Expand Down
4 changes: 4 additions & 0 deletions sdk/tables/azure-data-tables/src/xml_wrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@
#endif
#include <webservices.h>
#else
// libxml2 uses ICU. ICU 75.1 or later requires C++17 but we use
// C++14. It causes an error. We can disable ICU C++ API to avoid it
// because we don't need ICU C++ API.
#define U_SHOW_CPLUSPLUS_API 0
#include <libxml/xmlreader.h>
#include <libxml/xmlwriter.h>
#endif
Expand Down