Sync eng/common directory with azure-sdk-tools for PR 10857 #6624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
added
EngSys
There was a problem hiding this comment.
Pull Request Overview
This pull request syncs the eng/common directory with updates from azure-sdk-tools, introducing changes to parameter handling in API call scripts.
- Updated Search-GitHubIssues to accept an additional AuthToken parameter and construct the Invoke-RestMethod call using a parameters hashtable.
- Modified the ApiView-Helpers script to pass the new AuthToken parameter when fetching GitHub issues.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/common/scripts/Invoke-GitHubAPI.ps1 | Added AuthToken parameter and refactored REST API call to include conditional header initialization. |
| eng/common/scripts/Helpers/ApiView-Helpers.ps1 | Updated function call to Search-GitHubIssues to include the AuthToken parameter. |
Comments suppressed due to low confidence (2)
eng/common/scripts/Invoke-GitHubAPI.ps1:564
- [nitpick] Consider adding parameter attributes and inline documentation for $AuthToken to clarify its expected type and usage.
$AuthToken
eng/common/scripts/Helpers/ApiView-Helpers.ps1:135
- [nitpick] Ensure that the corresponding help text or documentation is updated to reflect the newly required AuthToken parameter.
$issuesForCommit = Search-GitHubIssues -CommitHash $HeadCommitish -AuthToken $AuthToken
chidozieononiwu
approved these changes
Jun 12, 2025
chidozieononiwu
deleted the
sync-eng/common-UserAuthTokenForSearchAPI-10857
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#10857 See eng/common workflow