[azcore] Add text [un]marshalling support to ResourceID #23381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbarnes
requested review from
RickWinter,
chlowell,
jhendrixMSFT and
richardpark-msft
as code owners
|
Thank you for your contribution @mbarnes! We will review the pull request and get back to you soon. |
github-actions
bot
added
Azure.Core
Community Contribution
mbarnes
pushed a commit
to Azure/ARO-HCP
that referenced
this pull request
Aug 30, 2024
This is a thinly wrappered azcorearm.ResourceID that implements the encoding.TextMarshaler and encoding.TextUnmarshaler interfaces, so that ResourceID can be used directly in structs that get built from JSON data. I proposed this for azcorearm.ResourceID in: Azure/azure-sdk-for-go#23381
mjlshen
pushed a commit
to Azure/ARO-HCP
that referenced
this pull request
Aug 30, 2024
This is a thinly wrappered azcorearm.ResourceID that implements the encoding.TextMarshaler and encoding.TextUnmarshaler interfaces, so that ResourceID can be used directly in structs that get built from JSON data. I proposed this for azcorearm.ResourceID in: Azure/azure-sdk-for-go#23381
|
Hi @mbarnes. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
github-actions
bot
added
the
no-recent-activity
|
My suggestion is still valid. Please leave open. |
github-actions
bot
removed
the
no-recent-activity
jhendrixMSFT
reviewed
Nov 1, 2024
|
Mind rebasing on |
mbarnes
force-pushed
the
resource-identifier-marshalling
branch
from
12cd44f
to
a4bea91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be handy for ResourceID to support the encoding.TextMarshaler and encoding.TextUnmarshaler interfaces so that, for example, JSON data that includes a resource ID string can be unmarshaled directly to a ResourceID struct (and vice versa for marshaling).