Throw if response from IMDS is not valid json #44073
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billwert
requested review from
maorleger,
pvaneck,
KarishmaGhiya,
chlowell and
mpodwysocki
chlowell
reviewed
Feb 7, 2025
| throw new RuntimeException(e); | ||
| } | ||
| HttpClient client = HttpClient.createDefault(new HttpClientOptions().setConnectTimeout(Duration.ofSeconds(1))); | ||
| HttpRequest request = new HttpRequest(HttpMethod.GET, url); |
There was a problem hiding this comment.
Is this a probe request or a fully formed token request? Edit: looks like it's the probe, in which case this would break ACI support (Azure/azure-sdk-for-go#23894). We want to interpret any response to the probe to mean managed identity is worth trying, and throw CredentialUnavailable if the endpoint then responds with a non-JSON body to a token request
There was a problem hiding this comment.
Just a probe. I'll rename the method and add a doc too.
There was a problem hiding this comment.
We should test ACI with this change.
|
API change check API changes are not detected in this pull request. |
alzimmermsft
reviewed
Feb 7, 2025
sdk/identity/azure-identity/src/main/java/com/azure/identity/implementation/IdentityClient.java
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/src/main/java/com/azure/identity/implementation/IdentityClient.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41291