Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for jca #44142

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Update for jca #44142

wants to merge 11 commits into from

Conversation

Netyyyy
Copy link
Member

@Netyyyy Netyyyy commented Feb 11, 2025

Description

  • Remove skipPublishDocMs in ci
  • Add descriptions for jar signer
  • Add descriptions for env options
  • Add/update descriptions and samples for ssl/tls and mtls

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@Netyyyy Netyyyy marked this pull request as draft February 11, 2025 02:10
@github-actions github-actions bot added azure-spring All azure-spring related issues KeyVault labels Feb 11, 2025
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@Netyyyy Netyyyy marked this pull request as ready for review February 14, 2025 06:36
@Netyyyy Netyyyy marked this pull request as draft February 14, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saragluna saragluna saragluna left review comments

@rujche rujche Awaiting requested review from rujche rujche is a code owner

@moarychan moarychan Awaiting requested review from moarychan moarychan is a code owner

@vcolin7 vcolin7 Awaiting requested review from vcolin7 vcolin7 is a code owner

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
azure-spring All azure-spring related issues KeyVault
Projects
Azure SDK for Key Vault
Status: Untriaged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Netyyyy @azure-sdk @saragluna