Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgmt, local generation for Storage - 2024-01-01 #44179

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

mgmt, local generation for Storage - 2024-01-01 #44179

wants to merge 5 commits into from

Conversation

v-hongli1
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Feb 13, 2025
@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 13, 2025 •
edited
Loading

API change check

API changes are not detected in this pull request.

@v-hongli1 v-hongli1 force-pushed the ReleaseIssues#5883 branch 3 times, most recently from 2f2903f to beb1cce Compare February 13, 2025 08:09
@v-hongli1 v-hongli1 closed this Feb 14, 2025
@v-hongli1 v-hongli1 reopened this Feb 14, 2025
@v-hongli1
Copy link
Member Author

The type of StorageAccountCheckNameAvailabilityParameters is now final, so add ignore item in revapi.json for fix ci analyze exception.

@v-hongli1
Copy link
Member Author

@weidongxu-microsoft @XiaofeiCao
The java - code-quality-reports - ci (Linting) always fails, even after merging the latest code from the master branch, it still fails with an exception. Do you have any good ideas?

@weidongxu-microsoft
Copy link
Member

what's the error?

my PR is good #44202

@v-hongli1
Copy link
Member Author

what's the error?

my PR is good #44202

https://dev.azure.com/azure-sdk/public/_build/results?buildId=4564739&view=logs&j=c6c4925b-6f50-5665-2367-bb7081498ed2&t=2fc9b57c-6b4c-5253-de06-6d8352a5ae8f

@weidongxu-microsoft
Copy link
Member

I am running it on main branch
https://dev.azure.com/azure-sdk/public/_build/results?buildId=4564866&view=results

If this also fails, we will notify Java Eng

@v-hongli1
Copy link
Member Author

@weidongxu-microsoft

I am running it on main branch https://dev.azure.com/azure-sdk/public/_build/results?buildId=4564866&view=results

If this also fails, we will notify Java Eng

This still fails, I think we must be notify Java Eng.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft left review comments

@mssfang mssfang Awaiting requested review from mssfang mssfang will be requested when the pull request is marked ready for review mssfang is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles will be requested when the pull request is marked ready for review JonathanGiles is a code owner

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft alzimmermsft will be requested when the pull request is marked ready for review alzimmermsft is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar will be requested when the pull request is marked ready for review srnagar is a code owner

@rujche rujche Awaiting requested review from rujche rujche will be requested when the pull request is marked ready for review rujche is a code owner

@Netyyyy Netyyyy Awaiting requested review from Netyyyy Netyyyy will be requested when the pull request is marked ready for review Netyyyy is a code owner

@saragluna saragluna Awaiting requested review from saragluna saragluna will be requested when the pull request is marked ready for review saragluna is a code owner

@moarychan moarychan Awaiting requested review from moarychan moarychan will be requested when the pull request is marked ready for review moarychan is a code owner

@haolingdong-msft haolingdong-msft Awaiting requested review from haolingdong-msft haolingdong-msft will be requested when the pull request is marked ready for review haolingdong-msft is a code owner

@XiaofeiCao XiaofeiCao Awaiting requested review from XiaofeiCao XiaofeiCao will be requested when the pull request is marked ready for review XiaofeiCao is a code owner

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 will be requested when the pull request is marked ready for review ArthurMa1978 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-hongli1 @azure-sdk @weidongxu-microsoft