Monitor Fix Missing ResourceId Bug #44186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jairmyree
requested review from
joshfree,
pvaneck,
KevinBlasko,
KarishmaGhiya,
scottaddie,
ToddKingMSFT and
Haiying-MSFT
|
API change check API changes are not detected in this pull request. |
srnagar
approved these changes
Feb 14, 2025
| } | ||
|
|
||
| @Test | ||
| public void testQueryResourcesReturnsNonNullResourceId() { |
There was a problem hiding this comment.
We don't need a separate test to check if resourceId is not null. We can just add an assertEquals to the previous test.
| @@ -75,4 +75,33 @@ public void testMetricsBatchQueryDifferentResourceTypes() { | |||
|
|
|||
| } | |||
|
|
|||
| @Test | |||
| public void testQueryResourcesReturnsNonNullResourceId() { | |||
There was a problem hiding this comment.
Same here - we can just update the previous test to check for resource id in the response.
| = metricsClient | ||
| .queryResourcesWithResponse(Arrays.asList(resourceId), Arrays.asList("HttpIncomingRequestCount"), | ||
| "microsoft.appconfiguration/configurationstores", options) | ||
| .block() |
There was a problem hiding this comment.
Async tests should not use block(). Use StepVerifier instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix for #43841