-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Remove unused dependencies from azure-identity #47307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes unused Redis-related dependencies (jedis, lettuce-core, and redisson) from the azure-identity module's test scope. These dependencies appear to have been used for sample code demonstrating Azure Identity integration with Redis clients, but that code has been removed.
- Removed three Redis client library dependencies from the pom.xml (jedis, lettuce-core, redisson)
- Cleaned up spotbugs exclusions for Redis-related sample classes
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/identity/azure-identity/pom.xml | Removed three test-scoped Redis client dependencies (jedis 6.2.0, lettuce-core 6.8.1.RELEASE, redisson 3.51.0) |
| sdk/identity/azure-identity/spotbugs-exclude.xml | Removed spotbugs exclusions for Redis-related sample classes that are no longer present |
Comments suppressed due to low confidence (1)
sdk/identity/azure-identity/spotbugs-exclude.xml:59
- Incomplete cleanup: The reference to
com.azure.jedis.Authenticatorat line 59 should also be removed. This class reference appears in a separate<Match>block for theUL_UNRELEASED_LOCK_EXCEPTION_PATHbug pattern and should be removed along with the other jedis-related exclusions.
<Class name="com.azure.jedis.Authenticator" />
joshfree
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add this to the CHANGELOG.md for the identity SDK :)
Description
Addresses feedback in #47221
Removed unused jetty, redisson, and lettuce-core dependencies from azure-identity.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines