Skip to content

Conversation

@anannya03
Copy link
Member

@anannya03 anannya03 commented Nov 17, 2025

Description

Addresses feedback in #47221

Removed unused jetty, redisson, and lettuce-core dependencies from azure-identity.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes unused Redis-related dependencies (jedis, lettuce-core, and redisson) from the azure-identity module's test scope. These dependencies appear to have been used for sample code demonstrating Azure Identity integration with Redis clients, but that code has been removed.

  • Removed three Redis client library dependencies from the pom.xml (jedis, lettuce-core, redisson)
  • Cleaned up spotbugs exclusions for Redis-related sample classes

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
sdk/identity/azure-identity/pom.xml Removed three test-scoped Redis client dependencies (jedis 6.2.0, lettuce-core 6.8.1.RELEASE, redisson 3.51.0)
sdk/identity/azure-identity/spotbugs-exclude.xml Removed spotbugs exclusions for Redis-related sample classes that are no longer present
Comments suppressed due to low confidence (1)

sdk/identity/azure-identity/spotbugs-exclude.xml:59

  • Incomplete cleanup: The reference to com.azure.jedis.Authenticator at line 59 should also be removed. This class reference appears in a separate <Match> block for the UL_UNRELEASED_LOCK_EXCEPTION_PATH bug pattern and should be removed along with the other jedis-related exclusions.
    <Class name="com.azure.jedis.Authenticator" />

Copy link
Member

@joshfree joshfree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this to the CHANGELOG.md for the identity SDK :)

@github-project-automation github-project-automation bot moved this from Untriaged to In Progress in Azure Identity SDK Improvements Nov 17, 2025
@anannya03 anannya03 merged commit 0e6e838 into Azure:main Nov 17, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure Identity SDK Improvements Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

5 participants