Skip to content

[mgmt] datafactory release #33819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

[mgmt] datafactory release #33819

wants to merge 13 commits into from

Conversation

kazrael2119
Copy link
Contributor

@Copilot Copilot AI review requested due to automatic review settings April 14, 2025 05:56
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Apr 14, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 328 out of 332 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • common/config/rush/pnpm-lock.yaml: Language not supported
  • sdk/datafactory/arm-datafactory/_meta.json: Language not supported
  • sdk/datafactory/arm-datafactory/assets.json: Language not supported
  • sdk/datafactory/arm-datafactory/package.json: Language not supported
Comments suppressed due to low confidence (13)

sdk/datafactory/arm-datafactory/samples-dev/credentialOperationsListByFactorySample.ts:23

  • The assignment for subscriptionId has been removed, leaving it undefined. Please ensure you declare and assign subscriptionId before using it in the client instantiation.
process.env["DATAFACTORY_SUBSCRIPTION_ID"] || "12345678-1234-1234-1234-12345678abc";

sdk/datafactory/arm-datafactory/samples-dev/credentialOperationsGetSample.ts:23

  • The subscriptionId variable is no longer assigned to a declared variable. Please restore the declaration to ensure proper client configuration.
process.env["DATAFACTORY_SUBSCRIPTION_ID"] || "12345678-1234-1234-1234-12345678abc";

sdk/datafactory/arm-datafactory/samples-dev/credentialOperationsDeleteSample.ts:23

  • The subscriptionId assignment has been removed. Declare and assign the subscriptionId variable so that it can be used when initializing the DataFactoryManagementClient.
process.env["DATAFACTORY_SUBSCRIPTION_ID"] || "12345678-1234-1234-1234-12345678abc";

sdk/datafactory/arm-datafactory/samples-dev/credentialOperationsCreateOrUpdateSample.ts:26

  • SubscriptionId is not assigned to a variable, which may lead to runtime errors when using it later. Please ensure it is declared (e.g., using const subscriptionId = ...) before usage.
process.env["DATAFACTORY_SUBSCRIPTION_ID"] || "12345678-1234-1234-1234-12345678abc";

sdk/datafactory/arm-datafactory/samples-dev/changeDataCaptureStopSample.ts:23

  • The subscriptionId assignment is missing its variable declaration. Restoring the assignment to a variable is required for proper client initialization.
process.env["DATAFACTORY_SUBSCRIPTION_ID"] || "12345678-1234-1234-1234-12345678abc";

sdk/datafactory/arm-datafactory/samples-dev/changeDataCaptureStatusSample.ts:23

  • The removal of the variable declaration for subscriptionId will cause it to be undefined later in the code. Please reintroduce a proper declaration.
process.env["DATAFACTORY_SUBSCRIPTION_ID"] || "12345678-1234-1234-1234-12345678abc";

sdk/datafactory/arm-datafactory/samples-dev/changeDataCaptureStartSample.ts:23

  • SubscriptionId is used without being assigned to a variable. Please ensure that a declaration like const subscriptionId = ... is added.
process.env["DATAFACTORY_SUBSCRIPTION_ID"] || "12345678-1234-1234-1234-12345678abc";

sdk/datafactory/arm-datafactory/samples-dev/changeDataCaptureListByFactorySample.ts:23

  • The subscriptionId value is not assigned to any variable after removal of the declaration. Please restore the variable assignment to avoid runtime errors.
process.env["DATAFACTORY_SUBSCRIPTION_ID"] || "12345678-1234-1234-1234-12345678abc";

sdk/datafactory/arm-datafactory/samples-dev/changeDataCaptureGetSample.ts:23

  • The subscriptionId assignment is missing a variable declaration, which may disrupt client configuration. Please add the appropriate declaration.
process.env["DATAFACTORY_SUBSCRIPTION_ID"] || "12345678-1234-1234-1234-12345678abc";

sdk/datafactory/arm-datafactory/samples-dev/changeDataCaptureDeleteSample.ts:23

  • Removing the variable declaration for subscriptionId leads to an undefined value later used by the client. Please reintroduce the variable assignment.
process.env["DATAFACTORY_SUBSCRIPTION_ID"] || "12345678-1234-1234-1234-12345678abc";

sdk/datafactory/arm-datafactory/samples-dev/changeDataCaptureCreateOrUpdateSample.ts:26

  • In the create function, subscriptionId is used without a proper variable declaration. Please restore the declaration to ensure it is correctly passed to the client.
process.env["DATAFACTORY_SUBSCRIPTION_ID"] || "12345678-1234-1234-1234-12345678abc";

sdk/datafactory/arm-datafactory/samples-dev/changeDataCaptureCreateOrUpdateSample.ts:56

  • In the update function, the subscriptionId assignment is missing. Please declare and assign subscriptionId before using it in the client instantiation.
process.env["DATAFACTORY_SUBSCRIPTION_ID"] || "12345678-1234-1234-1234-12345678abc";

sdk/datafactory/arm-datafactory/samples-dev/activityRunsQueryByPipelineRunSample.ts:26

  • The subscriptionId is evaluated but not assigned to a variable, potentially causing client instantiation to fail. Please declare subscriptionId appropriately.
process.env["DATAFACTORY_SUBSCRIPTION_ID"] || "12345678-1234-1234-1234-12345678abc";

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

@azure/arm-datafactory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants