Skip to content

[EngSys] remove npm cache from copilot setup #34504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

[EngSys] remove npm cache from copilot setup #34504

merged 1 commit into from
May 22, 2025

Conversation

@jeremymeng
Copy link
Member

@jeremymeng jeremymeng commented May 22, 2025

as currently we are using pnpm via rush.

@jeremymeng
[EngSys] remove npm cache from copilot setup
8a30d84 
as currently we are using pnpm via rush.
Copilot AI review requested due to automatic review settings May 22, 2025 00:22
@jeremymeng jeremymeng requested a review from a team as a code owner May 22, 2025 00:22
Copilot AI reviewed May 22, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the setting for npm caching from the copilot setup workflow since the project now uses pnpm via Rush.

  • Removed the "cache: 'npm'" configuration from the workflow.

@jeremymeng jeremymeng merged commit 2ca1f8e into main May 22, 2025
19 checks passed
@jeremymeng jeremymeng deleted the engsys/copilot-setup-remove-npm-cache branch May 22, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@deyaaeldeen deyaaeldeen deyaaeldeen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeremymeng @deyaaeldeen