-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Demo] Testing Copilot Review #48256
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
sdk/communication/Azure.Communication.Common/src/JwtTokenParser.cs:22
- [nitpick] The error message 'Token is not formatted correctly.' is used in multiple places. Consider providing more specific error messages to help with debugging.
const string TokenNotFormattedCorrectly = "Token is not formatted correctly.";
sdk/communication/Azure.Communication.Common/src/JwtTokenParser.cs:37
- Ensure that all possible exceptions thrown by 'Base64Url.DecodeString' are covered to avoid unhandled exceptions.
catch (ArgumentException ex)
API change check API changes are not detected in this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
sdk/communication/Azure.Communication.Common/src/JwtTokenParser.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
sdk/communication/Azure.Communication.Common/tests/JwtTokenParserTests.cs:25
- Add a test case for the scenario where an ArgumentException is thrown due to invalid characters in the token.
}
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.