-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for provisioning AI Foundry Projects #48314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 20 changed files in this pull request and generated 2 comments.
Files not reviewed (15)
- sdk/cloudmachine/Azure.CloudMachine.sln: Language not supported
- sdk/cloudmachine/Azure.Provisioning.CloudMachine/tests/Data/Foundry.bicep: Language not supported
- sdk/cloudmachine/Azure.Provisioning.CloudMachine/api/Azure.Provisioning.CloudMachine.net8.0.cs: Evaluated as low risk
- sdk/cloudmachine/Azure.CloudMachine.OpenAI/api/Azure.CloudMachine.OpenAI.net8.0.cs: Evaluated as low risk
- sdk/cloudmachine/Azure.CloudMachine.OpenAI/src/OpenAIFeature.cs: Evaluated as low risk
- sdk/cloudmachine/Azure.Provisioning.CloudMachine/src/FeaturesBuiltIn/ServiceBusSubscriptionFeature.cs: Evaluated as low risk
- sdk/cloudmachine/Azure.Provisioning.CloudMachine/src/FeaturesBuiltIn/StorageAccountFeature.cs: Evaluated as low risk
- sdk/cloudmachine/Azure.Provisioning.CloudMachine/src/FeaturesBuiltIn/ServiceBusNamespaceFeature.cs: Evaluated as low risk
- sdk/cloudmachine/Azure.Provisioning.CloudMachine/src/FeaturesBuiltIn/ServiceBusTopicFeature.cs: Evaluated as low risk
- sdk/cloudmachine/Azure.Provisioning.CloudMachine/src/CloudMachineInfrastructure/CloudMachineFeature.cs: Evaluated as low risk
- sdk/cloudmachine/Azure.Provisioning.CloudMachine/src/FeaturesExtensions/KeyVaultFeature.cs: Evaluated as low risk
- sdk/cloudmachine/Azure.Provisioning.CloudMachine/src/Tooling/Azd.cs: Evaluated as low risk
- sdk/cloudmachine/Azure.CloudMachine.OpenAI/api/Azure.CloudMachine.OpenAI.netstandard2.0.cs: Evaluated as low risk
- sdk/cloudmachine/Azure.Provisioning.CloudMachine/tests/BicepGenerationTests.cs: Evaluated as low risk
- sdk/cloudmachine/Azure.Provisioning.CloudMachine/api/Azure.Provisioning.CloudMachine.netstandard2.0.cs: Evaluated as low risk
Comments suppressed due to low confidence (2)
sdk/cloudmachine/Azure.Provisioning.CloudMachine/src/FeaturesBuiltIn/ResourceGroupFeature.cs:23
- The new behavior introduced in the ResourceGroupFeature class should be covered by tests to ensure it works as expected.
protected override ProvisionableResource EmitResources(ProjectInfrastructure cm)
sdk/cloudmachine/Azure.Provisioning.CloudMachine/src/FeaturesBuiltIn/AIFoundryFeature.cs:83
- The new behavior introduced in the EmitResources method should be covered by tests to ensure it works as expected.
protected override ProvisionableResource EmitResources(ProjectInfrastructure cm)
API change check APIView has identified API level changes in this PR and created following API reviews. |
this test illustrates the feature