Skip to content

Conversation

@violetVo
Copy link
Contributor

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

Copy link
Member

@mrm9084 mrm9084 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update for release

ArthurMa1978 and others added 15 commits December 9, 2025 23:31
…54412)

* add .NET 10 api listings to core/

* fix pipelines
* add more service owners under confidentialledger sdk

* remove yash as he is off atm

* add acl team directly
….0.0-alpha.20251205.1 (#54354)

* Regenerate repository SDK with TypeSpec build 20251205.1

* Update SDK code sc_wo_4

* Update SDK code co_dy_1

* Update SDK code ag_co_0

* Update SDK code mo_re_3

* Update SDK code ea_mo_2
* fix issue in renaming method parameter.

* refine
* Fixed the Performance of PersistentAgentsChatClient.GetStreamingResponseAsync

* Update sdk/ai/Azure.AI.Agents.Persistent/CHANGELOG.md

Co-authored-by: Copilot <[email protected]>

* Fix the comment

---------

Co-authored-by: Copilot <[email protected]>
* instruction fix

* description + instructions

---------

Co-authored-by: Juan Ospina <[email protected]>
* Fix link checks to npm for packages

* Apply suggestion from @Copilot

Co-authored-by: Copilot <[email protected]>

* Apply suggestion from @weshaggard

---------

Co-authored-by: Wes Haggard <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
Co-authored-by: Copilot <[email protected]>
…ateAndBuildV2 (#54384)

* Initial plan

* Add changelog creation logic for new libraries

Co-authored-by: JoshLove-msft <[email protected]>

* Add unit tests for changelog creation functionality

Co-authored-by: JoshLove-msft <[email protected]>

* Address code review feedback - remove duplicate variable initialization

Co-authored-by: JoshLove-msft <[email protected]>

* Improve error handling in changelog creation with more detailed messages

Co-authored-by: JoshLove-msft <[email protected]>

* Apply suggestions from code review

* Improve version validation to handle null/empty/whitespace values

Co-authored-by: JoshLove-msft <[email protected]>

* Address PR feedback: delete autorest.md and remove unnecessary comment

Co-authored-by: JoshLove-msft <[email protected]>

* Apply suggestions from code review

Co-authored-by: Copilot <[email protected]>

* Remove unused packageName parameter and delete autorest.md test file

Co-authored-by: JoshLove-msft <[email protected]>

* delete md file

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: JoshLove-msft <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: jolov <[email protected]>
* Used full pkg name in release work items

* Used full pkg name for dev ops work item

* Added test

* Pass in package info file path

* Reverted changes to verify-changelog.yml and script

* Updated script to process groupId in work items

* Renamed new property to GroupId

* Removed the condition check for Group

* Build hash key with non-null arguments

* Used the original BuildHashKey to return hash from non-null args

---------

Co-authored-by: ray chen <[email protected]>
* Update UnbrandedGeneratorVersion to 1.0.0-alpha.20251209.2

* fix

* update hook implementation

* simplify and use comparer

* build: Update UnbrandedGeneratorVersion to 1.0.0-alpha.20251210.1

---------

Co-authored-by: Ubuntu <cloudtest@15c9b478c000009.tkkhlgj2u51eln3mcb0lygmbye.dx.internal.cloudapp.net>
Co-authored-by: Jorge Rangel <[email protected]>
* bump the targeted proxy version
* bump in packages.data.props too
* resolve merge failure

---------

Co-authored-by: Scott Beddall <[email protected]>
Co-authored-by: Scott Beddall <[email protected]>
Copilot AI and others added 30 commits January 9, 2026 13:04
…operties by name (#54924)

* Initial plan

* Fix BuildConstructorParameters to correctly identify nested flattened properties

- Add CollectNestedFlattenedProperties helper method to recursively collect nested flattened properties for a given internal property
- Add IsInFlattenChain helper method to check if an internal property is in the flattening chain, supporting multi-level flattening
- Update BuildConstructorParameters to match constructor parameters by name first, then use the new helper methods to collect nested flattened properties
- This fixes issues where properties with the same type but different names (like prop1 and vmGalleryApplications) were incorrectly matched

Co-authored-by: live1206 <[email protected]>

* Remove unused IsDescendantOf method

Addressed code review feedback by removing the unused IsDescendantOf method.

Co-authored-by: live1206 <[email protected]>

* Address code review feedback

- Use list[0] instead of First() to avoid potential exceptions
- Add null check for list.Count > 0
- Add explanatory comment about why we skip adding parameters when innerFlattenedProperties is empty

Co-authored-by: live1206 <[email protected]>

* Add clarifying comments for code safety

- Add comment explaining list[0] is safe due to Count > 0 check
- Add note about recursion depth being shallow in practice for IsInFlattenChain

Co-authored-by: live1206 <[email protected]>

* Remove unused propertyTypeMap from cache

- Changed _flattenedModelTypes to only store Dictionary<string, List<FlattenPropertyInfo>> instead of a tuple
- Removed unused propertyTypeMap creation and storage
- Updated all access points to use the simplified structure
- All 71 tests passing

Co-authored-by: live1206 <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: live1206 <[email protected]>
* [EngSys] Package bumps and cleanup

The focus of these changes is to bump package versions,
remove implicit package reference targets, and clean up
legacy infrastructure.

Changes:
- Delete eng/AzSdk.reference.targets and eng/AzSdk.test.reference.targets
- Add explicit package references to 51 legacy projects
- Remove ImportDefaultReferences property from all files
- Add ApiCompatBaselineTargetFramework to legacy src projects
- Tighten legacy package block to require Microsoft.Azure prefix
- Scope xunit, BouncyCastle, FluentAssertions, and MSTest to specific projects

* AOT opt-out

* PR feedback tweaks
* Bump version for Azure.Generator

* use parameter from convenience method directly while populate operation method parameters

* cleanup

* bump version for Azure.Generator

* fix test
Because of the recent change to the API Compat ignore
list, there's a mismatch between exported API listings
for any library that used [EditorBrowsable].  The
focus of these changes is to do a repository-wide
API export to ensure that `main` is in a good state.
…resource attributes (role name/instance) (#54944)

* Fix performance counters not using configured resource attributes (role name/instance)

* changelog patch

* copilot feedback
Co-authored-by: Ubuntu <cloudtest@2ca85a10c000002.tkkhlgj2u51eln3mcb0lygmbye.dx.internal.cloudapp.net>
* changelog for 1.6.0-beta.2 release

* add in pr link
The focus of these changes is to archive the legacy
`Microsoft.Azure.Batch.Conventions.Files` and
`Microsoft.Azure.Batch.FileStaging` client libraries.
These are not under active development or maintenance,
and have been superseded by `Azure.Compute.Batch`.
* WIP add initial samples/README

* adding more samples and cleaning things up

* adding additional context

* delete extra client

* major reorganization of sample code

* addditional major reorganization of sample code

* revert

* clean up samples

* fix up tests

* update namespaces

* update assets

* fix up README

* typos

* push new recordings

* Modify README to comment out sample links

Updated README.md to replace links with comments for recorded tests, sync/async testing, unit testing, and test utilities.

* Update sample README links to include comments

* Update link to Contributing Guide in README.md

* Apply suggestions from code review

Co-authored-by: Jesse Squire <[email protected]>
Co-authored-by: Copilot <[email protected]>

* more feedback

* fix pipeline

---------

Co-authored-by: Jesse Squire <[email protected]>
Co-authored-by: Copilot <[email protected]>
* Fix renaming for resource model parameter

* update comment

* refine

* fix

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Model Inference AI Projects Client This issue is related to a non-management package CodeGen Issues that relate to code generation Event Grid Health Deidentification Image Analysis KeyVault Mgmt This issue is related to a management package. Monitor - Query Provisioning Schema Registry

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.