Fix renaming for resource model parameter #54985
Merged
+27
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
live1206
requested review from
ArcturusZhang,
JoshLove-msft,
jorgerangel-msft and
m-nash
as code owners
github-actions
bot
added
CodeGen
live1206
commented
Jan 13, 2026
...rp-mgmt/generator/Azure.Generator.Management/src/Utilities/OperationMethodParameterHelper.cs
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds a workaround to rename resource model parameters to "data" in the Azure Management Generator's operation method parameter helper. The change addresses an issue where resource model parameters aren't being renamed correctly by the existing BodyParameterNameNormalizer logic.
Changes:
- Adds explicit resource model parameter renaming logic before the existing body parameter normalization
- Includes a TODO comment indicating this should be handled by existing logic but needs investigation
...rp-mgmt/generator/Azure.Generator.Management/src/Utilities/OperationMethodParameterHelper.cs
Show resolved
Hide resolved
...rp-mgmt/generator/Azure.Generator.Management/src/Utilities/OperationMethodParameterHelper.cs
Show resolved
Hide resolved
...rp-mgmt/generator/Azure.Generator.Management/src/Utilities/OperationMethodParameterHelper.cs
Show resolved
Hide resolved
ArcturusZhang
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.