-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update the Cosmos crate README #2039
base: main
Are you sure you want to change the base?
Conversation
We've got a bit of a build issue. The @heaths Are we able to add |
Yes, we can add That said, isn't key auth less secure, such that maybe we shouldn't show it in the first thing people see/read? It's fine as an example, but maybe those under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing blocking, but a few recommendations.
This is a first pass at updating the README for the
azure_data_cosmos
crate. I based this on the Go package (https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/data/azcosmos/README.md) and updated the syntax and added some notes about the differences. I also borrowed from the ongoing work @ronniegeraghty is doing for the Identity create in #1990)Please take a close look to make sure I got all the Go related stuff converted properly. I'm also doing some further editing passes, but wanted to open things up for folks so they can take some time to find errors I may have made.