-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] [Storage] Blob download_blob
and upload_blob
APIs, BlobContainerClient
and BlobServiceClient
clients
#2108
Draft
vincenttran-msft
wants to merge
13
commits into
vincenttran/get_blob_props_mvp
Choose a base branch
from
vincenttran/2_11_25
base: vincenttran/get_blob_props_mvp
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[Draft] [Storage] Blob download_blob
and upload_blob
APIs, BlobContainerClient
and BlobServiceClient
clients
#2108
vincenttran-msft
wants to merge
13
commits into
vincenttran/get_blob_props_mvp
from
vincenttran/2_11_25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -15,19 +20,41 @@ async fn test_get_blob_properties() -> Result<(), Box<dyn Error>> { | |||
let credential = DefaultAzureCredentialBuilder::default().build()?; | |||
|
|||
// Act | |||
let container_client = BlobContainerClient::new( | |||
&endpoint, | |||
String::from("testcontainer1"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to figure out how to seed the container names similar to other languages (seeded random based on test name) since we keep hitting conflicting test container names.
ContainerClient
, upload_blob
, download_blob
download_blob
and upload_blob
APIs, BlobContainerClient
and BlobServiceClient
clients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR currently generates against vincenttran/blob-tsp-test2 which should roughly represent
v0.9.1
.This pull request contains the following:
BlobClient
download_blob
upload_blob
BlobContainerClient
BlobContainerClient
clientcreate_container
delete_container
ContainerProperties
andFromHeaders
implBlobServiceClient
BlobServiceClient
clientget_service_properties